minimal bootstrap for PythonService#729
Conversation
|
It does what I would like it to do. I've also added a clean_bootstraps command to p4a toolchain.py |
|
Nice. Would you be able to include my additions to the jni/src folder in the webview bootstrap to enable pyjnius to work with this bootstrap (plus some appropriate patch in the pyjnius recipe)? I think you just need to copy pyjniusjni.c and add it to the Android.mk. I don't see a recipe calling ndk-build to actually build the start.c. Am I missing something here, or you would call it separately once the dist is exported (I'd have thought this wouldn't work due to path problems)? |
|
The gradle build implicitly builds all .c files in the jni folder. Some documentation about how to import the build files from the dist into a Android Gradle project is needed I think. Thanks for merging all my PR's! |
180ac06 to
d0bf809
Compare
|
I rebased on ac25fab and added pyjniusjni.c but have not tested pyjnius. |
|
pyjnius will need a patch modification to work with this (currently it checks for the webviewjni recipe, but in retrospect this was a bad name and it should be something generic for all these bootstraps). If I merge this and make a couple of changes to that end, would you be able to test pyjnius in a trivial example (just import and autoclass)? (Other than that, sorry for the delay, am I right in understanding that this is working well for you?) |
|
Sorry for the delay. In the next couple of weeks I will be working on documentation. |
|
I've just confirmed pyjnius to work from the Python service with this script: 06-22 01:05:22.907 5503-5582/org.tribler.android:service_Triblerd I/System.out: Hello world |
|
Ready to merge :D Documentation is not yet included. |
|
Great, thanks! I changed 'clean_bootstraps' to 'clean_bootstrap_builds' for consistency. It would also be great if you could add a little doc about the purpose of this bootstrap, but there didn't seem to be a need to let it hold up merging the bulk of it. |
Meant to be used with export_dist to just run a Python service from a normal Android app.