Add distutils command for 'python setup.py apk'#764
Merged
Conversation
inclement
force-pushed
the
apk_distutils_command
branch
from
80fbf20 to
ad69375
Compare
inclement
force-pushed
the
apk_distutils_command
branch
from
ad69375 to
16597db
Compare
inclement
force-pushed
the
apk_distutils_command
branch
from
0bf122a to
bf1919d
Compare
Member
Author
|
This is now probably ready to merge, testing or comments welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not for merging yet (needs doc + cleanup), but basically works.
This adds a distutils command so that you can run
python setup.py apkto call p4a. It will use the normal setuptools information (name, version, package_data) unless otherwise specified, and you can also use all the normal p4a arguments.This works by papering over all the normal distutils behaviour (e.g. manually adding all the user arguments to the allowed list, since we want distutils to ignore them and let p4a handle it). I don't know if this could be done better.
I took the approach of using a normal distutils Command, but we could also provide our own setup() that would take extra arguments. This would be neater than the current
register_args, but I didn't do it initially because I haven't seen other packages do this, and it's a little awkward.(Edit: cx_freeze does provide its own setup, but I don't think we need to)