Added python modules check#794
Merged
Merged
Conversation
Member
Author
|
Per @tito on irc, he'd prefer this as a more generic check that could be applied in other projects too. I'm tempted to merge this anyway, since nothing will ever depend on it and it helps in the short term. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is a good idea, but can't hurt to ask and it would help with the regular problem of users not understanding error messages when modules aren't present (e.g. when buildozer hasn't installed them).
The code just checks if appropriate versions of each dependency are present, and prints clear errors if not. Currently if these are missing the user just gets an ImportError traceback.