Reworked argument handling#808
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not for merging quite yet, there are probably a few bugs left.
Everything now uses a single set of argparse subcommands, with arguments evaluated in one place and the args object passed to the methods, rather than the nester ArgumentParsers that were used before. This makes the structure clearer as arguments are managed in just one place, and allows argparse's automatic help to work propely (i.e.
p4a commandname --helpnow returns useful info).This could be improved further, e.g. probably separating out dist args to a separate parent parser rather than letting all commands accept them, but I think it can be merged in the current state as mostly a reworking rather than changing much internal behaviour.