Fix clean_download_cache, add deleting of separate packages#886
Merged
Conversation
inclement
requested changes
Oct 1, 2016
inclement
left a comment
inclement
left a comment
Member
There was a problem hiding this comment.
Nice change, would you be able to make a small change to the structure as annotated? I moved away from handling arguments in the individual methods so that users get more informative error messages if the command is wrong.
| msg = "Download cache removed!" | ||
|
|
||
| if args.unknown_args: | ||
| for package in args.unknown_args[0].split(','): |
Member
There was a problem hiding this comment.
Could you replace this with a parser_clean_download_cache.add_argument('recipes') when the parser is defined, instead? That will mean that the user gets a helpful argparse error message if they don't explicitly pass the intended argument. You could also just allow any number of arguments (I think for argparse something like nargs='*') instead of requiring the comma separation.
inclement
approved these changes
Oct 2, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.