allow to use system brotli library#6
Merged
Conversation
remicollet
force-pushed
the
issue-systemlibbroti
branch
from
345338b to
50e219b
Compare
remicollet
changed the title
Contributor
Author
|
According to a06a8d4 there is some change making 0.5.0 not compatible, reason why I set minimal version to 0.6.0 |
Owner
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
btw, perhaps this check can even be removed (PHP 4 still exists ?)
--with-libbrotliwill ignore the bundled library and use the system one.Tested (build + tests) with broti version 0.6.0 (available in Fedora) with PHP 5.4.45, 5.5.38, 5.6.32, 7.0.25, 7.1.12RC1 and 7.2.0RC6
Notice: using bundled library is usually forbidden in Linux distro (at least higly discouraged)
Bundled version is no more in php_brotly.h but instead in config.m4
AC_DEFINE_UNQUOTED(BROTLI_LIB_VERSION, "1.0.1", [bundled library version])Minimal supported version is also define in config.m4
BROTLI_MIN_VERSION=0.6