fix: nullable for ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE()

[kjdev]

Summary by CodeRabbit

• Refactor
  • Updated default values for certain parameters in Brotli compression functions for PHP 8 and above. Default values for "level" and "mode" parameters now use numeric zero instead of Brotli-specific constants in function signatures. There is no change to the behavior of the functions.

[coderabbitai]

Walkthrough

The changes update the argument information for several Brotli-related PHP functions by setting the default values of certain integer parameters (level and mode) to 0 instead of Brotli-specific constants for PHP 8 and above. No functional or control flow logic is altered—only the argument metadata is affected.

Changes

File(s)	Change Summary
brotli.c	Updated argument info for Brotli PHP functions to set default values of level and mode parameters to 0 (instead of Brotli constants) for PHP 8+. No change to function logic or implementation.

Possibly related PRs

• Feat/named arguments #66: Updates arginfo to add typed return and argument info, including default values for PHP 8+, which overlaps with this PR's changes to Brotli arginfo declarations.

Poem

In the warren where code is compressed tight,
Brotli's numbers now default to naught,
No more constants in the PHP night—
Just zeros where once magic was sought.
A hop, a nibble, and all is right!
🥕

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 663de30 and e29e59f.

📒 Files selected for processing (1)

• brotli.c (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (17)

• GitHub Check: ci (8.1, x86, ts, vs16, true)
• GitHub Check: ci (8.1, x64, ts, vs16, true)
• GitHub Check: ci (8.1, x86, nts, vs16, true)
• GitHub Check: ci (8.1, x64, nts, vs16, true)
• GitHub Check: ci (8.2, x64, ts, vs16, true)
• GitHub Check: ci (8.2, x86, nts, vs16, false)
• GitHub Check: ci (8.2, x86, nts, vs16, true)
• GitHub Check: ci (8.3, x86, nts, vs16, true)
• GitHub Check: ci (8.4, x86, ts, vs17, true)
• GitHub Check: ci (8.1-zts-alpine, php, linux/amd64)
• GitHub Check: ci (8.1-alpine, apcu, php, linux/386)
• GitHub Check: ci (8.4, x86, nts, vs17, true)
• GitHub Check: ci (8.1-alpine, system, apcu, php, linux/amd64)
• GitHub Check: ci (8.2-alpine, system, apcu, php, linux/amd64)
• GitHub Check: ci (8.2-zts-alpine, system, apcu, php, linux/amd64)
• GitHub Check: ci (8.3-zts-alpine, apcu, php, linux/amd64)
• GitHub Check: ci (8.4-alpine, apcu, php, linux/amd64)

🔇 Additional comments (4)

brotli.c (4)

38-39: Arginfo for brotli_compress now uses the correct PHP constants as defaults.
The default values "BROTLI_COMPRESS_LEVEL_DEFAULT" and "BROTLI_GENERIC" align with the registered constants (BROTLI_COMPRESS_LEVEL_DEFAULT, BROTLI_GENERIC) and match the implementation defaults (BROTLI_DEFAULT_QUALITY, BROTLI_MODE_GENERIC).

---

61-62: Arginfo for brotli_compress_init now uses matching PHP constants for defaults.
The default values "BROTLI_COMPRESS_LEVEL_DEFAULT" and "BROTLI_GENERIC" correctly reflect the C defaults and the registered constants.

---

74-74: Default value for the mode parameter in brotli_compress_add is correct.
Using "BROTLI_FLUSH" matches the registered constant and the implementation's default of BROTLI_OPERATION_FLUSH.

---

94-94: Default value for the mode parameter in brotli_uncompress_add is correct.
"BROTLI_FLUSH" aligns with the constant registration and the implementation default (BROTLI_OPERATION_FLUSH).

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[kjdev]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.