Feat mime type exclusions#101
Merged
Merged
Conversation
Allow excluding responses with specific MIME types (exact match or wildcard subtype) from transparent output compression via zstd.output_compression_exclude_types.
Cover exact match, wildcard match, match with a charset parameter, and the no-match case where compression still applies.
Add the option to the configuration table and describe its matching rules.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughAdds a new ChangesOutput compression MIME exclusion
Estimated code review effort: 2 (Simple) | ~12 minutes Sequence Diagram(s)sequenceDiagram
participant PHPScript
participant OutputHandler as php_zstd_output_handler
participant MimeChecker as php_zstd_output_mimetype_excluded
PHPScript->>OutputHandler: emit response with Content-Type
OutputHandler->>MimeChecker: check exclude_types against mimetype
MimeChecker-->>OutputHandler: excluded or not
OutputHandler-->>PHPScript: FAILURE (skip compression) or continue compression
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
image/*.Bug Fixes
Documentation
Tests