Rebuilding for electron fails

[krystianotto]

Hi, a very similar issue to #73

Apparently, rebuilding deps using electron-builder does not work.
Using legacy rebuilder, or skipping the rebuild altogether, is not an option, as it may break.

Stack trace

gyp info spawn args [ 'V=1', 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory '/home/user/projects/sdl-electron/node_modules/.pnpm/@kmamal+sdl@0.11.13/node_modules/@kmamal/sdl/build'
  touch Release/obj.target/../../../../node-addon-api@8.5.0/node_modules/node-addon-api/node_addon_api_except.stamp
  g++ -o Release/obj.target/sdl/src/native/module.o ../src/native/module.cpp '-DNODE_GYP_MODULE_NAME=sdl' '-DUSING_UV_SHARED=1' '-DUSING_V8_SHARED=1' '-DV8_DEPRECATION_WARNINGS=1' '-D_GLIBCXX_USE_CXX11_ABI=1' '-D_FILE_OFFSET_BITS=64' '-DELECTRON_ENSURE_CONFIG_GYPI' '-D_LARGEFILE_SOURCE' '-DUSING_ELECTRON_CONFIG_GYPI' '-DV8_COMPRESS_POINTERS' '-DV8_COMPRESS_POINTERS_IN_SHARED_CAGE' '-DV8_31BIT_SMIS_ON_64BIT_ARCH' '-DV8_ENABLE_SANDBOX' '-DV8_EXTERNAL_CODE_SPACE' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DOPENSSL_NO_ASM' '-DNAPI_VERSION=10' '-DNODE_ADDON_API_DISABLE_DEPRECATED' '-DNAPI_CPP_EXCEPTIONS' '-DBUILDING_NODE_EXTENSION' -I/home/user/.electron-gyp/39.0.0/include/node -I/home/user/.electron-gyp/39.0.0/src -I/home/user/.electron-gyp/39.0.0/deps/openssl/config -I/home/user/.electron-gyp/39.0.0/deps/openssl/openssl/include -I/home/user/.electron-gyp/39.0.0/deps/uv/include -I/home/user/.electron-gyp/39.0.0/deps/zlib -I/home/user/.electron-gyp/39.0.0/deps/v8/include -I -I../../../../../node-addon-api@8.5.0/node_modules/node-addon-api  -fPIC -pthread -Wall -Wextra -Wno-unused-parameter -Werror -Wall -Wextra -D_REENTRANT -m64 -O3 -fno-omit-frame-pointer -fno-rtti -fno-strict-aliasing -std=gnu++20 -std=c++17 -MMD -MF ./Release/.deps/Release/obj.target/sdl/src/native/module.o.d.raw   -c
../src/native/module.cpp:1:10: fatal error: napi.h: No such file or directory
    1 | #include <napi.h>
      |          ^~~~~~~~
compilation terminated.

A minimal repro
https://github.com/krystianotto/sdl-rebuild-example

Thanks for the great package!

[bmsuseluda]

it is prebuild and skipping never broke on my project. Did it break for you?

[krystianotto]

It's pre-built based on Node.js version, right? As far as I know, Electron may differ, e.g., the headers might be different, which can potentially cause issues. I had to explicitly exclude rebuilding SDL using electron-rebuild for now, as I have other native addons that require it

[monteslu]

curious about the use case for sdl with electron.

I'm using node-sdl in places that I can't use electron. Electron itself has access to windowing, audio, and input

[krystianotto]

Used for handling game controllers for now

[tloftis]

I may have a similar error with partial resolution, but building a windows targeted electron 39.1.1 app. Couldn't find header files because it couldn't find the SDL libraries files during compile.

Found I had to manually run the "download-sdl" (npm run download-sdl) for the package and had to update the binding.gyp to replace the SDL_LIB and SDL_INC variables myself before building.

It compiled but fails to fetch updates from SDL beyond the first frame. So no events are fired and no updated values for buttons, joysticks, ect...

Trying to use it as a way to refocus/hide the electron window with a button combination.