feature(workflow): added Kmeshctl doc syncing workflow#1498
feature(workflow): added Kmeshctl doc syncing workflow#1498kmesh-bot merged 3 commits intokmesh-net:mainfrom
Conversation
Signed-off-by: GitHub Action <action@github.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
@yashisrani: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
hzxuzhonghu
left a comment
There was a problem hiding this comment.
BTW, can you show how it works in your own repo
| - name: 🤝 Create Pull Request | ||
| uses: peter-evans/create-pull-request@v5 | ||
| with: | ||
| token: ${{ secrets.WEBSITE_PAT }} |
There was a problem hiding this comment.
we donot need to use a non exist token
There was a problem hiding this comment.
here, we use ${{ secrets.GITHUB_TOKEN }}, but The GITHUB_TOKEN is limited to the repository’s scope, with restricted permissions, no organization-level access, and limitations in forks, often requiring a custom PAT for broader or cross-repository actions.
we want to create a PR for website repo, then we want to use PAT, and if we want to create PR for this same repo (kmesh), then we can use GITHUB_TOKEN
There was a problem hiding this comment.
I can create the WEBSITE_PAT with the @kmesh-bot token, but first let me check if there exists one
There was a problem hiding this comment.
please use secrets.GH_PAT, then we can have a try
| # Use timestamp for a guaranteed unique branch name | ||
| branch-suffix: timestamp | ||
| base: main | ||
| title: "docs: sync latest kmeshctl documentation" |
There was a problem hiding this comment.
add the PR number that triggered it
There was a problem hiding this comment.
The workflow uses a push trigger, so ${{ github.event.number }} isn’t available (only for pull_request). I can add the commit SHA (${{ github.sha }}) for traceability or switch to a pull_request trigger. It successfully syncs kmesh/docs/ctl to kmesh-net/website.
There was a problem hiding this comment.
OK, i think github.sha looks good, we need a unique id to trace
i shared private repo pr links one week ago on slack channel, you approved as well. this workflow will first check on website, that kmeshctl folder available or not, if not then it will copy ctl folder from kmesh and create a pr for kmesh-website. if kmeshctl folder is availble in website, then it will see the kmeshctl doc content changes, if changes are detected then it will create a pr for new changes in website. |
| base: main | ||
| title: "docs: sync latest kmeshctl documentation" | ||
| body: | | ||
| This PR syncs the latest changes from [kmesh/docs/ctl](https://github.com/yashisrani/kmesh/tree/main/docs/ctl). |
Signed-off-by: GitHub Action <action@github.com>
Signed-off-by: GitHub Action <action@github.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
/kind documentation
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1412
Setup Instructions:
Step 1: Create a Fine-Grained Personal Access Token (PAT)
Step 2: Add Secret to kmesh Repository
Special notes for your reviewer:
Does this PR introduce a user-facing change?: