Skip to content

Fix to return null instead of removing node when autoClose is true #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Normaltic merged 1 commit into from
Dec 17, 2024
Merged

Fix to return null instead of removing node when autoClose is true #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/DaumPostcodeEmbed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export type DaumPostcodeProps = DaumPostcodeEmbedProps;

interface State {
hasError: boolean;
completed: boolean;
}

const defaultErrorMessage = <p>현재 Daum 우편번호 서비스를 이용할 수 없습니다. 잠시 후 다시 시도해주세요.</p>;
Expand All @@ -50,6 +51,7 @@ class DaumPostcodeEmbed extends Component<DaumPostcodeEmbedProps, State> {

state = {
hasError: false,
completed: false,
};

componentDidMount() {
Expand All @@ -72,7 +74,7 @@ class DaumPostcodeEmbed extends Component<DaumPostcodeEmbedProps, State> {
...options,
oncomplete: (address) => {
if (onComplete) onComplete(address);
if (autoClose && this.wrap.current) this.wrap.current.remove();
this.setState({ completed: true });
},
onsearch: onSearch,
onresize: onResize,
Expand All @@ -90,8 +92,10 @@ class DaumPostcodeEmbed extends Component<DaumPostcodeEmbedProps, State> {
};

render() {
const { className, style, errorMessage } = this.props;
const { hasError } = this.state;
const { className, style, errorMessage, autoClose } = this.props;
const { hasError, completed } = this.state;

if (autoClose === true && completed === true) return null;

return (
<div ref={this.wrap} className={className} style={{ ...defaultStyle, ...style }}>
Expand Down