DRAFT: Initial files for 2023 TOC Elections by geekygirldawn · Pull Request #1332 · knative/community

geekygirldawn · 2023-04-26T12:50:29Z

Here is a PR with the initial files required to kick off the Knative 2023 TOC elections.

Before this PR can be merged:

@jberkus needs to confirm that he can have everything needed to set up Elekto done by May 2.
@knative/steering-committee needs to officially appoint the election officers. We've proposed @geekygirldawn and @aliok.
@knative/steering-committee needs to make sure they are OK with the timeline and other details proposed in this PR.

/hold

geekygirldawn · 2023-04-26T12:53:09Z

Note: I've left @jberkus in the OWNERS file deliberately in case there are any urgent issues, especially related to Elekto, that might come up when the Election Officers are offline (esp due to time zones).

geekygirldawn · 2023-04-26T13:59:38Z

Note: There is bugfix for Elekto that needs to be pushed before this PR is merged. The plan is for it to be merged before the end of the week.

aliok

LGTM

I compared files with Knative TOC 2022 election and Kubernetes SC 2022 election files. Suggested some optional minor changes.

I am curious about the elections@knative.team address though.

All good!

aliok · 2023-04-26T21:04:14Z

+- [Dawn Foster](https://github.com/geekygirldawn)
+- [Ali Ok](https://github.com/aliok)
+
+You can reach us by emailing elections@knative.team


Who receives mails to this address? Are we sure that this inbox is working?

Ah, good question! That alias is configured in groups.yaml and I've updated it there as another commit within this PR. We'll need to wait until the PR is merged and then test it to make sure it's working.

Onceagain12

Summit

knative-prow · 2023-04-27T09:55:27Z

@Onceagain12: changing LGTM is restricted to collaborators

Details

In response to this:

Summit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Ali Ok <aliok@redhat.com>

lance

Looks good overall - thanks for getting this going, @geekygirldawn! I just have a few minor comments

Applied several changes to improve wording / clarity. Co-authored-by: Lance Ball <lball@redhat.com>

geekygirldawn · 2023-05-01T06:41:59Z

I've addressed all of the feedback on this PR, so we can remove the hold and merge the PR as soon as @jberkus confirms that he's pushed the changes to Elekto that we needed.

jberkus · 2023-04-28T22:24:15Z

@@ -24,4 +24,4 @@ groups:
    members:
      - fosterd@vmware.com
      - jberkus@redhat.com


We should probably take me off here; I'm not an officer this time.

We talked about this and would like to leave Josh on the ML for the election officers in case there are any urgent Elekto issues that come up in Pacific time, since Ali and I are both in European time zones.

…ittees

…lekto

Made several updates that clarify and correct some information about Elekto Co-authored-by: Josh Berkus <josh@agliodbs.com>

…sh more time to set up Elekto

geekygirldawn · 2023-05-02T09:08:32Z

We've pushed the announcement date for the election to May 3 to give Josh some extra time to set up Elekto and make sure we have everything ready for the announcement.

Co-authored-by: Ali Ok <aliok@redhat.com>

jberkus · 2023-05-02T21:14:32Z

/remove-hold
/lgtm

Ready to merge.

salaboy · 2023-05-03T07:10:34Z

/lgtm

salaboy · 2023-05-03T07:14:06Z

/approve

knative-prow · 2023-05-03T07:14:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geekygirldawn, Onceagain12, salaboy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [salaboy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

geekygirldawn added 2 commits April 26, 2023 11:56

Initial files required for 2023 TOC election

8aded46

added everyone with 50+ commits in devstats as of 2023-04-23

7031887

knative-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2023

knative-prow Bot requested review from lance and puerco April 26, 2023 12:50

knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 26, 2023

aliok reviewed Apr 26, 2023

View reviewed changes

Onceagain12 approved these changes Apr 27, 2023

View reviewed changes

geekygirldawn and others added 2 commits April 27, 2023 11:05

also adding Ali Ok to the elections email alias

9293db7

Apply aliok's suggestions from code review

88647c9

Co-authored-by: Ali Ok <aliok@redhat.com>

lance reviewed Apr 28, 2023

View reviewed changes

Comment thread elections/2023-TOC/README.md Outdated

Comment thread elections/2023-TOC/README.md Outdated

Comment thread elections/2023-TOC/README.md Outdated

Comment thread elections/2023-TOC/election_desc.md Outdated

geekygirldawn and others added 2 commits May 1, 2023 07:30

Apply Lance's suggestions from code review

8fe2688

Applied several changes to improve wording / clarity. Co-authored-by: Lance Ball <lball@redhat.com>

spelled out entire address to mailing lists for clarity

0f934f4

jberkus suggested changes May 1, 2023

View reviewed changes

knative-prow Bot assigned jberkus May 1, 2023

geekygirldawn and others added 4 commits May 2, 2023 09:48

added SC / TC members who are eligble to vote for being on those comm…

2d4bbd6

…ittees

updated several usernames to get around the case sensitivity bug in E…

6103f12

…lekto

Apply suggestions from jberkus

c7d067e

Made several updates that clarify and correct some information about Elekto Co-authored-by: Josh Berkus <josh@agliodbs.com>

changed the announcement day to be May 3, instead of May 2 to give Jo…

811a136

…sh more time to set up Elekto

aliok reviewed May 2, 2023

View reviewed changes

Comment thread elections/2023-TOC/README.md Outdated

Apply suggestions from Ali

0ff2b1d

Co-authored-by: Ali Ok <aliok@redhat.com>

knative-prow Bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 2, 2023

knative-prow Bot assigned salaboy May 3, 2023

salaboy self-requested a review May 3, 2023 07:13

salaboy approved these changes May 3, 2023

View reviewed changes

knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023

knative-prow Bot merged commit c34a8ef into knative:main May 3, 2023

Conversation

geekygirldawn commented Apr 26, 2023

Uh oh!

geekygirldawn commented Apr 26, 2023

Uh oh!

geekygirldawn commented Apr 26, 2023

Uh oh!

aliok left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aliok Apr 26, 2023

Choose a reason for hiding this comment

Uh oh!

geekygirldawn Apr 27, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Onceagain12 left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow Bot commented Apr 27, 2023

Uh oh!

lance left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

geekygirldawn commented May 1, 2023

Uh oh!

Uh oh!

Uh oh!

jberkus Apr 28, 2023

Choose a reason for hiding this comment

Uh oh!

geekygirldawn May 2, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

geekygirldawn commented May 2, 2023

Uh oh!

Uh oh!

jberkus commented May 2, 2023

Uh oh!

salaboy commented May 3, 2023

Uh oh!

salaboy commented May 3, 2023

Uh oh!

knative-prow Bot commented May 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants