Skip to content

[wip] make use of new go1.24 so we don't need x/net/h2c package#3298

Closed
dprotaso wants to merge 6 commits intoknative:mainfrom
dprotaso:update-h2c
Closed

[wip] make use of new go1.24 so we don't need x/net/h2c package#3298
dprotaso wants to merge 6 commits intoknative:mainfrom
dprotaso:update-h2c

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Nov 30, 2025

  • drop use of old h2c package
  • run ./hack/update-dep.sh

@knative-prow knative-prow bot requested a review from Cali0707 November 30, 2025 17:06
@knative-prow
Copy link

knative-prow bot commented Nov 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from skonto November 30, 2025 17:06
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 30, 2025
@dprotaso dprotaso changed the title make use of new go1.24 so we don't need x/net/h2c package [wip] make use of new go1.24 so we don't need x/net/h2c package Nov 30, 2025
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2025
@dprotaso dprotaso mentioned this pull request Nov 30, 2025
Closed
@codecov
Copy link

codecov bot commented Nov 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 23.33333% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.43%. Comparing base (e853b1d) to head (b24adc6).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
network/transports.go 28.00% 36 Missing ⚠️
network/server.go 0.00% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3298      +/-   ##
==========================================
- Coverage   74.58%   74.43%   -0.15%     
==========================================
  Files         188      188              
  Lines        8187     8211      +24     
==========================================
+ Hits         6106     6112       +6     
- Misses       1841     1860      +19     
+ Partials      240      239       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso dprotaso mentioned this pull request Dec 1, 2025
Merged
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2025
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 19, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

skonto
skonto reviewed Dec 28, 2025
View reviewed changes
network/server.go
Protocols: &protocols,

// https://medium.com/a-journey-with-go/go-understand-and-mitigate-slowloris-attack-711c1b1403f6
ReadHeaderTimeout: time.Minute,
Copy link
Contributor

@skonto skonto Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we care about MaxHeaderBytes to make it configurable?

Copy link
Member Author

@dprotaso dprotaso Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure - circling back on this PR I realize we can't just remove the h2c upgrade flow because that can break existing workloads.

In theory we need

  1. Add support for h2 prior knowledge
  2. deprecated h2c upgrade flow
  3. then eventually drop h2c upgrade flow in some future release

@dprotaso
Copy link
Member Author

dprotaso commented Jan 12, 2026

Going to close this out for now

@dprotaso dprotaso closed this Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skonto skonto skonto left review comments

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dprotaso @knative-prow-robot @skonto