Respect user's light/dark mode choice - #4
Open
midnight-wonderer wants to merge 1 commit into
Open
Conversation
knu
force-pushed
the
main
branch
3 times, most recently
from
November 24, 2024 05:59
0b1e79e to
ee17121
Compare
|
On my machine, the generated docs respect light/dark mode system settings (and dark/light mode switcher in Dash). The addition/removal of the |
|
Hmm, maybe I was wrong. I am a bit confused by the behavior. Now it seems that switching to dark mode just makes Dash somewhat-intelligently invert colors of a page. The Tailwind dark theme doesn't seem to be used. |
Author
|
I am using it on Zeal, BTW. It is Dash compatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is this static
darkclass in thehtmlelements.Normally, this class has to be added by the display application.
However, since the class is in static HTML, the documents are always displayed in dark mode.
Can we respect both choices?