Adapt to Tailwind v4 - #8
Conversation
| # Make the header sticky | ||
| thead = table.at('thead') | ||
| tbody = table.at('tbody') | ||
| thead.add_class(%w(sticky top-0 bg-white border-b)) |
There was a problem hiding this comment.
If dark mode controlled by the dark variant actually worked, we would have to also add the dark:bg-gray-950 class.
I wanted table items whose tables are not scrollable to have the 8px top-padding when they are searched from Dash, similarly to the scrollable tables which also have to count the sticky header.
|
Sorry for the delayed response. I have been lazy, as my own projects haven’t even looked at migrating from v3 to v4. Yesterday, I came across this news about the recent layoffs and the current business situation: Learning that offline documentation could potentially affect the sustainability of their business has made me hesitate. As an individual contributor, I’m unsure whether continuing to distribute downloadable offline docs on this project or push updates to Dash is something I should keep doing, if there’s a risk of harming the Tailwind CSS project in that way. With that in mind, I’m inclined to proceed with reviewing this PR and probably merging it, while possibly refraining from publishing or pushing the built v4 documentation for now. |
|
@knu Wow, I hadn't heard about this. I suspect most folks using this docset haven't either. The only ethical compromise I can think of is including all the "tailwind PLUS" documentation (https://tailwindcss.com/plus) in this docset. i.e. include the unfree sections ...and unfree classes Definitely makes the offline docset larger and less convenient, but still far more convenient than online docs - without actively participating in killing the project. Would be happy to make this version, I'm just super busy for the next few weeks. |
|
Hi, this is unfortunate news! 😞 What about adding a decent ad somewhere on each page of the docset? For example
|
|
In my opinion, Tailwind's docset is essential for web developers (in Dash). In everyday work, it's pointless to open the website every time you want to quickly look something up. At the moment, we just create a shortcut to the documentation, which doesn't contain any advertising anyway. But that would be fair: we include a bold note at the end that draws attention to the project as such and links to the home page. |
this is a good middle ground, and a lot harder to "mentally adblock" than a link or some other static reference to the pro offering |
5 participants
As I promised, here's the PR to make the generator work with Tailwind 4 (closes #7).
The site has been completely redesigned, so I had to change all the selectors and the code removing all the undesired stuff like navbars.
Also it seems that they are no longer producing the Next.js metadata with
buildIdso I am fetching latest commit sha for the site from GitHub. Similarly, I am fetching latest version of Tailwind itself from GitHub, as they now show onlyv4.1(notv4.1.10) in the site header. As these requests to GitHub are not authenticated, they count towards the 60 requests per hour per IP rate limit, but this seems okay to me.Here's the built docset: Tailwind_CSS.docset.zip.