Skip to content

Fix panic in expression context.#269

Merged
japaric merged 1 commit intoknurling-rs:mainfrom
Dirbaio:panic-expr
Nov 24, 2020
Merged

Fix panic in expression context.#269
japaric merged 1 commit intoknurling-rs:mainfrom
Dirbaio:panic-expr

Conversation

@Dirbaio
Copy link
Contributor

@Dirbaio Dirbaio commented Nov 23, 2020

Fixes #268.

@Dirbaio Dirbaio changed the title Fix macro in expression context. Fix panic in expression context. Nov 23, 2020
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, that's subtle. nice catch!

@japaric japaric merged commit 7197a4c into knurling-rs:main Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic! macro should be an expression returning ! (Never type)

2 participants