Skip to content

Implement Format for the core::{iter, ops, slice} structs.#472

Merged
bors[bot] merged 3 commits intoknurling-rs:mainfrom
richard-uk1:impl_format_for_range
May 15, 2021
Merged

Implement Format for the core::{iter, ops, slice} structs.#472
bors[bot] merged 3 commits intoknurling-rs:mainfrom
richard-uk1:impl_format_for_range

Conversation

@richard-uk1
Copy link
Contributor

No description provided.

@Urhengulas
Copy link
Member

Is it on purpose that RangeTo is omitted?

@richard-uk1
Copy link
Contributor Author

Is it on purpose that RangeTo is omitted?

Oops! Added now :)

@richard-uk1 richard-uk1 force-pushed the impl_format_for_range branch from 65bc251 to b5f17e1 Compare May 15, 2021 10:35
Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

bors r+

@bors
Copy link
Contributor

bors bot commented May 15, 2021

Build succeeded:

@bors bors bot merged commit f6270ae into knurling-rs:main May 15, 2021
@Urhengulas
Copy link
Member

I will add snapshot tests in a separate PR

@Urhengulas Urhengulas changed the title Implement Format for the core::ops structs. Implement Format for the core::{iter, ops, slice} structs. May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants