Redesign Dice.from_dist to sample density on an evenly-spaced grid#17
Merged
Conversation
Replaces the quantile-slicing approach with PDF sampling: one face per outcome on a min..max grid stepped by `step`, weighted by the density. This makes the dice's bar chart reproduce the shape of the distribution. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks
Dice.from_distto approximate a continuous distribution by sampling its PDF on an evenly-spaced grid (min/max/step) rather than slicing equiprobable quantiles, so the resulting dice's bar chart reproduces the shape of the density. It now requires a.pdfmethod (NormalDistor frozenscipy.stats), derives a defaultmean ± 3·stdrange whenmin/maxare omitted, and raises clear errors for a non-positive step, an inverted range, or a range that captures no mass. The notebook docs and examples were updated to match, the--watchflag was added to the marimo run command in.conductor/settings.toml, and the tests and formatting were refreshed accordingly.