Remove "i" x-axis title from dice charts#18
Merged
Conversation
prob_chart and cdf_chart named their outcome column "i", and qplot uses the field name as the axis title with no way to suppress it. Clear the x-axis title on the returned chart so the charts show no x-axis label. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dice charts rendered
"i"as the x-axis title becauseprob_chartandcdf_chartnamed their DataFrame outcome column"i", andhastyplot.qplotuses the field name as the axis title with no option to suppress it. This clears the x-axis title on the returned chart in both methods so the charts show no x-axis label. Changes are made in the source notebooknbs/__init__.pyand the generateddicekit/__init__.py(viamake build); all 47 tests pass.🤖 Generated with Claude Code