Use * for multiple dice rolls and @ for value scaling#7
Merged
Conversation
Dice multiplication by an integer now sums that many independent rolls, matching tabletop notation like 3d6. Scalar value scaling moves to @ (matmul), so d6 @ 3 multiplies each face value by 3. Fixes #3 Co-authored-by: vincent d warmerdam <koaning@users.noreply.github.com>
Co-authored-by: vincent d warmerdam <koaning@users.noreply.github.com>
Co-authored-by: vincent d warmerdam <koaning@users.noreply.github.com>
koaning
marked this pull request as ready for review
June 9, 2026 10:07
…e-dice-mul-7666 # Conflicts: # dicekit/__init__.py # nbs/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
Summary
Changes dice multiplication semantics to match tabletop notation:
d6 * 3(or3 * d6) now rolls three six-sided dice and sums the results — equivalent tod6 + d6 + d6d6 @ 3(or3 @ d6) scales each face value by a scalar — the previous behavior of*Multiplying two
Diceobjects with*still computes the product of independent rolls.Examples
Testing
test_dice_reflected_operationsto use@for scalar scalingtest_dice_mul_counts_rollsandtest_dice_matmul_scales_values