Merged
Conversation
Member
Author
|
Dropping this in favor of #1778 |
Member
Author
|
@jnm we decided not to use stylelint in #1778 but then reverted this decision in #1790 - so I want to bring this back, as writing neatier css code is always a plus. I touched a few files to remove errored lines, but am not doing any autofix all, so it will be easier to merge it. Plus now stylelint will be run with test/build scripts, so no bad stuff allowed in production code anymore. |
Member
Author
|
@Eric-Dilcher I assigned this to you too, as you probably have something to say in this matter :) |
jnm
reviewed
Feb 4, 2019
| position: relative; | ||
| overflow: visible; | ||
|
|
||
| &--visible {} |
Member
There was a problem hiding this comment.
I would guess that someone left these empty blocks as a hint for future developers. You're the one working on it, though, so if you want to get rid of them, that's fine with me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I based the file on https://github.com/stylelint/stylelint-config-recommended and https://github.com/stylelint/stylelint-config-standard - just removed few and changed most to warnings
@pmusaraj should I apply autofix on all our files in this PR?