`npm install` fails on master branch

[alex-phillips]

It looks like npm install fails on the master branch. Is this known?

[phanan]

Erm… no? The build still passes on Travis.

[alex-phillips]

will try again real quick, but i pulled now a fresh master today and it failed. Will paste my output if i fails again.

[alex-phillips]

Here's my output:

➜ npm install
npm WARN deprecated node-uuid@1.4.7: use uuid module instead
npm WARN deprecated to-iso-string@0.0.2: to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN prefer global marked@0.3.6 should be installed with -g
npm WARN prefer global node-gyp@3.5.0 should be installed with -g

> node-sass@4.5.0 install /home/aphillips/tmp/koel/node_modules/laravel-mix/node_modules/node-sass
> node scripts/install.js

Cached binary found at /home/aphillips/.npm/node-sass/4.5.0/linux-x64-51_binding.node

> node-sass@3.13.1 install /home/aphillips/tmp/koel/node_modules/node-sass
> node scripts/install.js

Cached binary found at /home/aphillips/.npm/node-sass/3.13.1/linux-x64-51_binding.node

> node-sass@4.5.0 postinstall /home/aphillips/tmp/koel/node_modules/laravel-mix/node_modules/node-sass
> node scripts/build.js

Binary found at /home/aphillips/tmp/koel/node_modules/laravel-mix/node_modules/node-sass/vendor/linux-x64-51/binding.node
Testing binary
Binary is fine

> node-sass@3.13.1 postinstall /home/aphillips/tmp/koel/node_modules/node-sass
> node scripts/build.js

Binary found at /home/aphillips/tmp/koel/node_modules/node-sass/vendor/linux-x64-51/binding.node
Testing binary
Binary is fine

> koel@ postinstall /home/aphillips/tmp/koel
> yarn build

yarn build v0.18.2
$ node node_modules/cross-env/bin/cross-env.js NODE_ENV=production node_modules/webpack/bin/webpack.js --progress --hide-modules 
/home/aphillips/tmp/koel/webpack.config.js:146
            Mix.cssOutput(toCompile)
                ^

TypeError: Mix.cssOutput is not a function
    at Mix.preprocessors.forEach.toCompile (/home/aphillips/tmp/koel/webpack.config.js:146:17)
    at Array.forEach (native)
    at Object.<anonymous> (/home/aphillips/tmp/koel/webpack.config.js:144:23)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at requireConfig (/home/aphillips/tmp/koel/node_modules/webpack/bin/convert-argv.js:96:18)
    at /home/aphillips/tmp/koel/node_modules/webpack/bin/convert-argv.js:109:17
    at Array.forEach (native)
    at module.exports (/home/aphillips/tmp/koel/node_modules/webpack/bin/convert-argv.js:107:15)
    at Object.<anonymous> (/home/aphillips/tmp/koel/node_modules/webpack/bin/webpack.js:153:40)
    at Module._compile (module.js:571:32)
error Command failed with exit code 1.

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.1.1: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN sass-loader@5.0.1 requires a peer of node-sass@^4.0.0 but none was installed.
npm ERR! Linux 4.9.10-200.fc25.x86_64
npm ERR! argv "/home/aphillips/.nvm/versions/node/v7.5.0/bin/node" "/home/aphillips/.nvm/versions/node/v7.5.0/bin/npm" "install"
npm ERR! node v7.5.0
npm ERR! npm  v4.1.2
npm ERR! code ELIFECYCLE
npm ERR! koel@ postinstall: `yarn build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the koel@ postinstall script 'yarn build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the koel package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     yarn build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs koel
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls koel
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/aphillips/tmp/koel/npm-debug.log

[phanan]

Can you try yarn instead of npm install?

[phanan]

Looks like npm install pulls a newer, breaking, version of Laravel Mix.

[alex-phillips]

Ok, that looks like it did it. Thanks!

[vesper8]

this really should be changed so that it's compatible with the latest laravel mix. I too was using npm and ran into the same error. Not sure why it works with yarn.. probably because of the yarn.lock file preventing it from getting the latest laravel mix. But "use yarn instead" and closing the issue feels incomplete to me.

[phanan]

The official docs state the use of yarn, so no, I don't think it's incomplete.

[gerroon]

The official doc mentions yarn but it does not say use yarn instead of npm. Please correct it.

[phanan]

@gerroon It's because you don't even need to execute any yarn or npm yourself. There's nothing to correct.

[gerroon]

@phanan
Well I am not sure then because I followed exact these steps in the docs,

cd PUBLIC_DIR
git clone https://github.com/phanan/koel.git .
git checkout v3.7.0 # Check out the latest version at https://github.com/phanan/koel/releases
composer install
php artisan koel:init # Populate credentials during the process

php artisan serve

I was getting bunch of php errors in the page when I tried to open the page.

Then I downgraded to nodejs to 6 (I originally had nodejs 8 I believe) and used yarn then composer and it worked.

[gerroon]

@phanan

Just to prove my point I did a clean install from scratch without using "yarn", I did steps that the doc says, which I posted above entry.

This is what I get in the browser when trying to open the page (unless I run yarn install prior)

So I am not sure how I can relate to your comment about the user not needeing to fire yarn/npm install

Whoops, looks like something went wrong.
(2/2) ErrorException

file_get_contents(/var/www/html/koel/public/mix-manifest.json): failed to open stream: No such file or directory (View: /var/www/html/koel/resources/views/index.blade.php)
in Application.php (line 52)
at CompilerEngine->handleViewException(object(ErrorException), 1)in PhpEngine.php (line 44)
at PhpEngine->evaluatePath('/var/www/html/koel/storage/framework/views/78e695689c1f04e709656c0e33cfd14b1acd7d20.php', array('__env' => object(Factory), 'app' => object(Application)))in CompilerEngine.php (line 59)
at CompilerEngine->get('/var/www/html/koel/resources/views/index.blade.php', array('__env' => object(Factory), 'app' => object(Application)))in View.php (line 137)
at View->getContents()in View.php (line 120)
at View->renderContents()in View.php (line 85)
at View->render()in Response.php (line 38)
at Response->setContent(object(View))in Response.php (line 200)
at Response->__construct(object(View))in Router.php (line 615)
at Router->prepareResponse(object(Request), object(View))in Router.php (line 572)
at Router->Illuminate\Routing\{closure}(object(Request))in Pipeline.php (line 30)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in Pipeline.php (line 102)
at Pipeline->then(object(Closure))in Router.php (line 574)
at Router->runRouteWithinStack(object(Route), object(Request))in Router.php (line 533)
at Router->dispatchToRoute(object(Request))in Router.php (line 511)
at Router->dispatch(object(Request))in Kernel.php (line 176)
at Kernel->Illuminate\Foundation\Http\{closure}(object(Request))in Pipeline.php (line 30)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in TransformsRequest.php (line 30)
at TransformsRequest->handle(object(Request), object(Closure))in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in TransformsRequest.php (line 30)
at TransformsRequest->handle(object(Request), object(Closure))in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in ValidatePostSize.php (line 27)
at ValidatePostSize->handle(object(Request), object(Closure))in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in UseDifferentConfigIfE2E.php (line 27)
at UseDifferentConfigIfE2E->handle(object(Request), object(Closure))in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in CheckForMaintenanceMode.php (line 46)
at CheckForMaintenanceMode->handle(object(Request), object(Closure))in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in Pipeline.php (line 102)
at Pipeline->then(object(Closure))in Kernel.php (line 151)
at Kernel->sendRequestThroughRouter(object(Request))in Kernel.php (line 116)
at Kernel->handle(object(Request))in index.php (line 52)
(1/2) ErrorException

file_get_contents(/var/www/html/koel/public/mix-manifest.json): failed to open stream: No such file or directory
in Application.php (line 52)
at HandleExceptions->handleError(2, 'file_get_contents(/var/www/html/koel/public/mix-manifest.json): failed to open stream: No such file or directory', '/var/www/html/koel/app/Application.php', 52, array('file' => '/css/app.css', 'manifestFile' => '/var/www/html/koel/public/mix-manifest.json', 'manifest' => null))
at file_get_contents('/var/www/html/koel/public/mix-manifest.json')in Application.php (line 52)
at Application->rev('/css/app.css')in Facade.php (line 221)
at Facade::__callStatic('rev', array('/css/app.css'))in 78e695689c1f04e709656c0e33cfd14b1acd7d20.php (line 21)
at include('/var/www/html/koel/storage/framework/views/78e695689c1f04e709656c0e33cfd14b1acd7d20.php')in PhpEngine.php (line 42)
at PhpEngine->evaluatePath('/var/www/html/koel/storage/framework/views/78e695689c1f04e709656c0e33cfd14b1acd7d20.php', array('__env' => object(Factory), 'app' => object(Application)))in CompilerEngine.php (line 59)
at CompilerEngine->get('/var/www/html/koel/resources/views/index.blade.php', array('__env' => object(Factory), 'app' => object(Application)))in View.php (line 137)
at View->getContents()in View.php (line 120)
at View->renderContents()in View.php (line 85)
at View->render()in Response.php (line 38)
at Response->setContent(object(View))in Response.php (line 200)
at Response->__construct(object(View))in Router.php (line 615)
at Router->prepareResponse(object(Request), object(View))in Router.php (line 572)
at Router->Illuminate\Routing\{closure}(object(Request))in Pipeline.php (line 30)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in Pipeline.php (line 102)
at Pipeline->then(object(Closure))in Router.php (line 574)
at Router->runRouteWithinStack(object(Route), object(Request))in Router.php (line 533)
at Router->dispatchToRoute(object(Request))in Router.php (line 511)
at Router->dispatch(object(Request))in Kernel.php (line 176)
at Kernel->Illuminate\Foundation\Http\{closure}(object(Request))in Pipeline.php (line 30)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in TransformsRequest.php (line 30)
at TransformsRequest->handle(object(Request), object(Closure))in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in TransformsRequest.php (line 30)
at TransformsRequest->handle(object(Request), object(Closure))in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in ValidatePostSize.php (line 27)
at ValidatePostSize->handle(object(Request), object(Closure))in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in UseDifferentConfigIfE2E.php (line 27)
at UseDifferentConfigIfE2E->handle(object(Request), object(Closure))in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in CheckForMaintenanceMode.php (line 46)
at CheckForMaintenanceMode->handle(object(Request), object(Closure))in Pipeline.php (line 148)
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))in Pipeline.php (line 53)
at Pipeline->Illuminate\Routing\{closure}(object(Request))in Pipeline.php (line 102)
at Pipeline->then(object(Closure))in Kernel.php (line 151)
at Kernel->sendRequestThroughRouter(object(Request))in Kernel.php (line 116)
at Kernel->handle(object(Request))in index.php (line 52)