You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The SchemaStore submodule advances by 81 commits (ba06047 → fd0ba84). The two changes relevant to this project (which only consumes github-workflow.json and github-action.json) are:
dbc0fd17 — Add code-quality to GitHub Workflow permissions (#5736)
Adds "code-quality" as a valid permission scope inside permissions: blocks. Before this, using permissions: code-quality: write in a workflow would produce a false-positive unknown key diagnostic from ghasec's generated validator.
3fdf6895 — Fix GitHub workflow event type constraints (#5796)
Structural fix: changes event object definitions from direct $ref (which overrides sibling properties in JSON Schema draft-07) to allOf: [{$ref}] for all event types (branch_protection_rule, check_run, issue_comment, pull_request, release, etc.). This properly preserves the sibling items.enum constraints for event types: fields in the compiled schema, rather than relying on raw-JSON extraction. This resolves a class of incorrect type constraint warnings that affected issue_comment with types: [opened] (which opened is not a valid type for that event — the schema was previously not enforcing this).
fd0ba84d — build(deps-dev): bump js-yaml from 4.1.1 to 4.2.0 (#5835)
Final commit; bumps SchemaStore's own dev tooling. No schema content changed.
github-action.json was not modified in this range.
🎯 Impact Scope Investigation
PR diff: Only the Git submodule pointer changes (schemastore from ba06047 to fd0ba84). The committed rules/invalid-workflow/generated.go (~706 KB) and rules/invalid-action/generated.go (~114 KB) are not touched.
Runtime impact of this PR alone: zero. The build system does not run go generate automatically. All validation code lives in the committed generated.go files, which remain unchanged. Existing tests will continue to pass.
Impact after running go generate (a subsequent step):
code-quality will be accepted as a valid permission key (additive, no regressions).
The allOf-wrapped $ref pattern allows the JSON Schema compiler to properly include items.enum for event types. The extractEventTypeEnums workaround in cmd/gen/event_types.go guards against this: its extractTypesEnumFromProperties function checks for a direct "$ref" key on the types property (line 110), which will now be absent (replaced by allOf). However, since the schema fix makes the compiler correctly include those enums natively, the injection step is no longer needed — and the converter's AllOf branch traversal in convert.go will propagate the items.enum correctly. Net result: correct, equivalent generated code.
github-action.json unchanged — rules/invalid-action/generated.go requires no regeneration.
💡 Recommended Actions
Merge this PR — it is safe. The submodule pointer update is a required prerequisite for the next step.
Follow up with a go generate commit: After merging, run the following to regenerate and commit the updated validator:
go generate ./rules/invalid-workflow/ ./rules/invalid-action/
go test ./...
git add rules/invalid-workflow/generated.go rules/invalid-action/generated.go
git commit -m "chore: regenerate from updated SchemaStore schema"
This will activate the code-quality permission support and the corrected event type constraints.
No migration steps required — all schema changes are additive or bug-fixing; no hand-written rule logic in invalid_workflow.go or invalid_action.go needs updating.
renovateBot
changed the title
chore(deps): update schemastore digest to d1c9b66
chore(deps): update schemastore digest to fd0ba84
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
ba06047→fd0ba84Configuration
📅 Schedule: (UTC)
* 0-4,22-23 * * 1-5)* * * * 0,6)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.