Use face :foreground and :background when both are set instead of computing foreground value

[DivineDominion]

This took me a while to figure out :)

I'm not color blind, but deficient, and I really like modus-themes deuteranopia variants for that. With flyover, it was too much tone-in-tone, though.

No tint:

Lighter (default):

Darker:

I'd like to use yellow background with black text for warning (which I could get with 100% 'darker' tint), and red background with white text for errors (which I could get with 100% lighter tint), but I can't control both.

I believe I'd be able to make a PR that uses face :foreground for text and :background for, well, the background if both are present. If either is missing, assume the only color there is the background which then is tinted.

Is this in scope of the project?

[konrad1977]

Do we want a switch to swap them, or maybe better use a custom color as a fallback?

[konrad1977]

Its hopefully fixed in 742e235

(use-package flyover
  :ensure nil
  :hook ((flycheck-mode . flyover-mode))
  :config
  (add-hook 'flycheck-mode-hook #'flyover-mode)
   (set-face-attribute 'flyover-info nil
                       :foreground "Cyan1"
                       :background "Cyan4")

  (set-face-attribute 'flyover-warning nil
                       :foreground "black"
                       :background "yellow")

  ;; ;; Red background with white text for errors
  (set-face-attribute 'flyover-error nil
                       :foreground "red"
                       :background "red4")
  :custom
  ;; Checker settings
  (flyover-checkers '(flymake flycheck))
  (flyover-levels '(error warning info))
  (flyover-show-at-eol t)
  (flyover-line-position-offset 0)

  ;; Appearance
  (flyover-use-theme-colors nil) ;; <- turn of theme colors

  (flyover-icon-background-tint 'lighter)
  (flyover-icon-background-tint-percent 40)

  (flyover-icon-tint 'darker)
  (flyover-icon-tint-percent 50)

  (flyover-text-tint 'darker)
  (flyover-text-tint-percent 80)

  ;; Padding
  (flyover-icon-left-padding 0.55)

  ;; Border styles: none, pill, arrow, slant, slant-inv, flames, pixels
  (flyover-border-style 'slant)
  (flyover-border-match-icon t)

  ;; Display settings
  (flyover-hide-checker-name t)
  (flyover-show-virtual-line t)
  (flyover-virtual-line-type 'none)
  (flyover-line-position-offset 1)
  (flyover-show-error-id t)

  ;; Message wrapping
  (flyover-wrap-messages t)
  (flyover-max-line-length 80)

  ;; Performance
  (flyover-debounce-interval 0.2)
  (flyover-cursor-debounce-interval 0.3)
  (flyover-display-mode 'always))