fix: when using --qa-enable and --qa-disable the answers to disabled questions were not being added to the generated config file#1163
Merged
HarikrishnanBalagopal merged 2 commits intokonveyor:mainfrom Mar 21, 2024
Conversation
|
Thanks for making a pull request! 😃 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
- Coverage 14.84% 14.83% -0.01%
==========================================
Files 90 90
Lines 8367 8379 +12
==========================================
+ Hits 1242 1243 +1
- Misses 6802 6813 +11
Partials 323 323 ☔ View full report in Codecov by Sentry. |
1a6956b to
283afd2
Compare
…questions were not being added to the generated config file Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
283afd2 to
820b163
Compare
ashokponkumar
approved these changes
Mar 21, 2024
…sabled questions were not being added to the generated config file Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.