Skip to content

Init the logging parts of the config before calling init_logging#751

Merged
kpet merged 3 commits intokpet:mainfrom
rjodinchr:pr/init-logging
Mar 29, 2025
Merged

Init the logging parts of the config before calling init_logging#751
kpet merged 3 commits intokpet:mainfrom
rjodinchr:pr/init-logging

Conversation

@rjodinchr
Copy link
Copy Markdown
Contributor

This is needed when logging properties are set in a configuration file.

@rjodinchr
Copy link
Copy Markdown
Contributor Author

I will try to implement what we talked about this week:

Initialise a subset of the config before init_logging, and the rest after. That would make for 2 init_config functions, not sure of their name right now.

This is needed when logging properties are set in a configuration
file.
@rjodinchr rjodinchr changed the title init logging a second time after init_config Init the logging parts of the config before calling init_logging Jan 27, 2025
@kpet kpet self-requested a review March 17, 2025 17:40
Copy link
Copy Markdown
Owner

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kpet kpet merged commit f1589ab into kpet:main Mar 29, 2025
9 checks passed
@rjodinchr rjodinchr deleted the pr/init-logging branch March 31, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants