Skip to content

Update deps and CTS#844

Open
kpet wants to merge 4 commits intomainfrom
update
Open

Update deps and CTS#844
kpet wants to merge 4 commits intomainfrom
update

Conversation

@kpet
Copy link
Copy Markdown
Owner

@kpet kpet commented Jan 12, 2026

Change-Id: I7b5794e9d9c4ab9ba5c6acbb42dbe8eacd91c371

@kpet kpet requested a review from Copilot January 17, 2026 11:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates external dependencies and refreshes conformance test suite (CTS) results for multiple test configurations (llvmpipe, Intel A750, AMD 7950X) across updated Mesa and LLVM versions.

Changes:

  • Updated external dependency submodule references for clspv, SPIRV-Tools, SPIRV-LLVM-Translator, SPIRV-Headers, and OpenCL-Headers
  • Refreshed CTS test results reflecting updates from Mesa 25.2.2 to 25.3.3 and LLVM 20.1.8 to 21.1.8
  • Updated test case coverage with added/removed/renamed tests and modified test results (pass/fail/skip status changes)

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/conformance/results-llvmpipe.json Updated CTS results for llvmpipe configuration with new API/driver versions and test case changes
tests/conformance/results-llvmpipe-physical.json Updated CTS results for llvmpipe physical device configuration
tests/conformance/results-intel-a750.json Updated CTS results for Intel A750 GPU with new Mesa driver version
tests/conformance/results-intel-a750-physical.json Updated CTS results for Intel A750 physical device configuration
tests/conformance/results-amd-7950x.json Updated CTS results for AMD 7950X CPU integrated graphics
tests/conformance/results-amd-7950x-physical.json Updated CTS results for AMD 7950X physical device configuration
external/clspv Updated clspv submodule commit reference
external/SPIRV-Tools Updated SPIRV-Tools submodule commit reference
external/SPIRV-LLVM-Translator Updated SPIRV-LLVM-Translator submodule commit reference
external/SPIRV-Headers Updated SPIRV-Headers submodule commit reference
external/OpenCL-Headers Updated OpenCL-Headers submodule commit reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rjodinchr
Copy link
Copy Markdown
Contributor

I think this PR just needs to update the SPIRV-LLVM-Translator to the version matching clspv.

@kpet
Copy link
Copy Markdown
Owner Author

kpet commented Feb 5, 2026

Yes but the second clspv/LLVM update may or may not fix the CMake/Ninja problem on windows. EDIT: looks like the required changes have not landed in the translator's main yet.

@rjodinchr
Copy link
Copy Markdown
Contributor

Yes but the second clspv/LLVM update may or may not fix the CMake/Ninja problem on windows. EDIT: looks like the required changes have not landed in the translator's main yet.

LLVM 23 has not been released yet, but LLVM main is already at 23. The translator is stuck as requiring 22 as long as official 23 LLVM packages are not released.

That's again a sign that we should consider having a clspv branch following LLVM releases to avoid such issues.

@rjodinchr
Copy link
Copy Markdown
Contributor

We are making a llvm/release/22.x branch in clspv. I think that would be the one to use for clvk. And then update from release to release to avoid llvm's trunk. We can always backport commit in clspv's llvm/release/x.x branches if we really need to.
google/clspv#1558

Change-Id: I7b5794e9d9c4ab9ba5c6acbb42dbe8eacd91c371
@rjodinchr
Copy link
Copy Markdown
Contributor

This is not going to work. We need the fix for the presubmit from #850

@kpet
Copy link
Copy Markdown
Owner Author

kpet commented Mar 24, 2026

Thanks for pointing that out. I'll cherry pick it. I'm also struggling to build locally (facing issues with libclc now).

@rjodinchr
Copy link
Copy Markdown
Contributor

The clspv pointed by this PR is too recent. Please reset it to google/clspv@a3d9d290.
#850 should have validated that point. Then we will see to update it to ToT.

That point should unlock what we need for the PR in clvk, and it will avoid bringing unstable stuff that we have in clspv at the moment (regarding libclc).

kpet added 2 commits March 28, 2026 08:31
Change-Id: If28d74c5bb52d113dae3e61298c480f3429f704a
Change-Id: I5ebcc388dc302dd043dd6f9e2fc659729144c1bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants