Thane updated to first major beta version - v0.1.1#1981
Open
timlouw wants to merge 1 commit intokrausest:masterfrom
Open
Thane updated to first major beta version - v0.1.1#1981timlouw wants to merge 1 commit intokrausest:masterfrom
timlouw wants to merge 1 commit intokrausest:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Thane benchmark implementation to use the latest Thane framework, improves code style and maintainability, and refactors the row selection logic to be more idiomatic and reactive. The most significant changes include updating dependencies and scripts for Thane 0.1.x, refactoring row selection to use signals instead of direct DOM manipulation, and improving code formatting for readability.
Cleared all PR code notes:
Framework and Dependency Updates:
thanedependency from version0.0.48to^0.1.1in bothpackage.jsonandpackage-lock.json, and updated theframeworkVersionaccordingly. [1] [2] [3]enginesfield inpackage-lock.jsonto requirebuninstead ofnode.package.jsonto include the correct--basepath for output assets.Codebase Refactoring and Improvements:
benchmark.tsto use a reactiveselectedsignal instead of direct DOM manipulation, improving state management and code clarity. The<tr>element now uses thedangerclass based on the selected row's id, and selection is handled by updating the signal. [1] [2] [3]