Skip to content

Thane updated to first major beta version - v0.1.1#1981

Open
timlouw wants to merge 1 commit intokrausest:masterfrom
timlouw:tim/thane-updates
Open

Thane updated to first major beta version - v0.1.1#1981
timlouw wants to merge 1 commit intokrausest:masterfrom
timlouw:tim/thane-updates

Conversation

@timlouw
Copy link
Contributor

@timlouw timlouw commented Mar 10, 2026

This pull request updates the Thane benchmark implementation to use the latest Thane framework, improves code style and maintainability, and refactors the row selection logic to be more idiomatic and reactive. The most significant changes include updating dependencies and scripts for Thane 0.1.x, refactoring row selection to use signals instead of direct DOM manipulation, and improving code formatting for readability.

Cleared all PR code notes:

BOTH CODE NOTES FROM PREVIOUS PRs HAVE NOW BEEN FIXED:
Note https://github.com/krausest/js-framework-benchmark/issues/801 (Event Delegation): The implementation uses manual event delegation on the tbody element via _handleTableClick.
Note https://github.com/krausest/js-framework-benchmark/issues/772 (Manual DOM Manipulation): The implementation uses manual DOM manipulation to handle row selection (row.className = 'danger').

Framework and Dependency Updates:

  • Upgraded the thane dependency from version 0.0.48 to ^0.1.1 in both package.json and package-lock.json, and updated the frameworkVersion accordingly. [1] [2] [3]
  • Updated the engines field in package-lock.json to require bun instead of node.
  • Adjusted build and dev scripts in package.json to include the correct --base path for output assets.

Codebase Refactoring and Improvements:

  • Refactored row selection logic in benchmark.ts to use a reactive selected signal instead of direct DOM manipulation, improving state management and code clarity. The <tr> element now uses the danger class based on the selected row's id, and selection is handled by updating the signal. [1] [2] [3]
  • Improved formatting of the adjectives and nouns arrays and cleaned up code style for readability and consistency.
  • Updated event handler signatures and formatting for better maintainability and to match the new selection logic. [1] [2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant