Batch insert#145
Open
ibarrick wants to merge 3 commits intokrisajenkins:masterfrom
Open
Conversation
|
Isn't this a duplicate of #135? |
Author
|
It achieves the same purpose with much fewer changes. |
|
will this be merged? |
joelittlejohn
added a commit
to audiogum-forks/yesql
that referenced
this pull request
Dec 15, 2017
dkmarley
pushed a commit
to dkmarley/yesql
that referenced
this pull request
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
submitting an array of maps to an insert query should now insert all the records as a batch.
Also changed the assertions about non matching args to be IllegalArgumentExceptions because that makes it possible for them to be captured by exception handlers and dealt with.