Act on a transition instead of logging it

AGENTS.md

@@ -31,6 +31,7 @@ Dependency rule (Go-enforced, no cycles): `dialect ← engine ← crq`, `state 
   Owns persistent filesystem and process I/O for checkouts; `crq` supplies only
   configured roots and a current-token resolver.
 - `internal/state/` — persisted schema v4: one `Round` per PR, one global
+- `internal/state/` — persisted schema v3: one `Round` per PR, one global
   `FireSlot`, the CodeRabbit `AccountQuota`, an `Archive` ring. Round transition
   methods, durable tombstones for tidied trigger comments, the CAS store, and
   dashboard rendering. `Round.CoBots` holds per-

README.md

@@ -397,6 +397,9 @@ crq feedback <repo> <pr>  # current normalized findings as JSON, WITHOUT trigger
 crq threads <repo> <pr>                                     # every unresolved thread, outdated included
 crq resolve <thread-id> [<thread-id>...]                    # resolve addressed review threads
 crq decline <thread-id> [...] --reason "<why>" [--resolve]  # record why a finding is declined
+crq drain install         # ⭐ unattended: watch every PR and fix what needs fixing
+crq watch                 #    what the drain runs: drive open PRs through crq next, one JSON
+                          #    line each (--dispatch starts a fix session; --once for cron)
 crq hold <repo> <pr> --reason "<why>"                       # persistently stop reviews for a PR
 crq unhold <repo> <pr>                                      # resume reviews for a held PR
 crq hold                                                    # list held PRs
@@ -486,7 +489,7 @@ Set these in `~/.config/crq/env` (sourced automatically) or as environment varia
 | `CRQ_SCOPE` | owner of `CRQ_REPO` | which owners/orgs share this quota (comma-separated) |
 | `CRQ_STATE_REF` | `crq-state-v3` | git ref that stores the typed CAS state |
 | `CRQ_REPOS` | _(all in scope)_ | `autoreview` allowlist — only these `owner/name` repos (comma-separated) |
-| `CRQ_EXCLUDE` | _(none)_ | `autoreview` denylist — never these `owner/name` repos (comma-separated) |
+| `CRQ_EXCLUDE` | _(none)_ | denylist — crq never reviews, watches or fixes these `owner/name` repos (comma-separated) |
 | `CRQ_AUTOREVIEW_SKIP_AUTHORS` | `dependabot[bot]` | PR authors `autoreview` never enqueues (comma-separated; case and `[bot]` suffix don't matter) — set to empty to auto-review bot PRs too; manual `crq review` is unaffected |
 | `CRQ_AUTOREVIEW_SKIP_MARKER` | `<!-- crq:skip-autoreview -->` | exact PR-body marker that suppresses fleet auto-review; set empty to disable; manual `crq loop` is unaffected |
 | `CRQ_TIDY` | `0` | set to `1` to delete crq's own spent review-trigger comments as rounds progress (`crq tidy` by hand is unaffected) |

cmd/crq/doctor_installs_test.go

@@ -0,0 +1,62 @@
+package main
+
+import (
+	"os"
+	"path/filepath"
+	"testing"
+)
+
+// One stale crq erased every dispatch claim in the fleet, and nothing said so.
+// doctor cannot stop it — the binary that does the damage is older than any
+// mechanism meant to catch it — but it can name it.
+func TestOtherInstallsNamesADifferentBuild(t *testing.T) {
+	self, err := os.Executable()
+	if err != nil {
+		t.Fatal(err)
+	}
+	mine, err := os.ReadFile(self)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	stale := t.TempDir()
+	same := t.TempDir()
+	if err := os.WriteFile(filepath.Join(stale, "crq"), []byte("an older build"), 0o755); err != nil {
+		t.Fatal(err)
+	}
+	if err := os.WriteFile(filepath.Join(same, "crq"), mine, 0o755); err != nil {
+		t.Fatal(err)
+	}
+	t.Setenv("PATH", stale+string(os.PathListSeparator)+same)
+	t.Setenv("GOPATH", t.TempDir()) // no crq there: an empty directory is not a finding
+
+	found := otherInstalls()
+	if len(found) != 2 {
+		t.Fatalf("found %d installs, want the two planted ones: %+v", len(found), found)
+	}
+	byPath := map[string]otherInstall{}
+	for _, in := range found {
+		byPath[in.Path] = in
+	}
+	if in, ok := byPath[filepath.Join(stale, "crq")]; !ok || in.SameBuild {
+		t.Errorf("the stale build was not reported as different: %+v", in)
+	}
+	if in, ok := byPath[filepath.Join(same, "crq")]; !ok || !in.SameBuild {
+		t.Errorf("a copy of this build was reported as different: %+v", in)
+	}
+}
+
+// A directory on PATH that holds no crq, or holds something unexecutable, is
+// not a second install.
+func TestOtherInstallsIgnoresWhatItCannotRun(t *testing.T) {
+	empty := t.TempDir()
+	unexec := t.TempDir()
+	if err := os.WriteFile(filepath.Join(unexec, "crq"), []byte("notes"), 0o644); err != nil {
+		t.Fatal(err)
+	}
+	t.Setenv("PATH", empty+string(os.PathListSeparator)+unexec)
+	t.Setenv("GOPATH", t.TempDir())
+	if found := otherInstalls(); len(found) != 0 {
+		t.Errorf("reported %+v, want nothing", found)
+	}
+}