-
Notifications
You must be signed in to change notification settings - Fork 0
Keep the fleet's policy in one place instead of on every machine #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
b226a0f
Choose which bots review which project
kristofferR 5acbd05
Let a project add a reviewer, not only remove one
kristofferR 7fbcd45
Never gate a repository on a reviewer crq will not ask
kristofferR c3cba22
Refuse a reviewers command that looks like it worked
kristofferR 37d0bc2
Recognise a completion reply as a reviewed head
kristofferR e09bfae
Requeue only the pull requests a reviewer change can strand
kristofferR 375d9c1
Reach a pull request the reviewer change could not
kristofferR c50f705
Hold the fire slot until the primary answers
kristofferR 0ff2ba1
Hold the same fire slot on the loop's way out
kristofferR cb869fb
Ask the current configuration, not the one the decision read
kristofferR 9467b4b
Hold the slot for the command, not for the head
kristofferR ceb60ad
Preserve review state across configuration changes
kristofferR 942d684
Fix review state compatibility races
kristofferR 770df01
Keep legacy writers behind orphaned holds
kristofferR 330cf83
Fix reviewer reconfiguration races
kristofferR ae9badb
Fix reviewer reconfiguration edge cases
kristofferR a454a83
Address reviewer configuration feedback
kristofferR 90e78e9
Fix reviewer override and slot hold edge cases
kristofferR 1aaab68
Keep the fleet's policy in one place instead of on every machine
kristofferR b1b7da3
Merge remote-tracking branch 'origin/main' into feat/fleet-config
kristofferR 4e5f21e
Apply fleet policy consistently
kristofferR 1ad6b79
Fence fleet policy updates and account state
kristofferR 0907c5e
Apply fleet policy consistently across background work
kristofferR b883db8
Fix fleet drain configuration previews
kristofferR 7c2db6b
Fix fleet policy review edge cases
kristofferR bda5407
Close fleet policy gaps in retry, hold and reporting
kristofferR fc44056
Put the co-reviewer policy in the fleet registry
kristofferR dfabaf9
Close fleet policy gaps in exclusion, seeding and feedback
kristofferR bb92a38
Judge first fleet values as the policy changes they are
kristofferR c696658
Judge every host input that carries fleet policy
kristofferR d35b0c5
Reread fleet policy where a stale copy would spend a review
kristofferR 93ade4e
Hold fleet policy where a stale copy still decides
kristofferR 02a094f
Keep a policy decision from outliving what it was read for
kristofferR 3426711
Spend no repository scan on a fleet setting that is not moving
kristofferR ca3f36a
Read fleet state once for a drain preview
kristofferR b9a2f23
Read the fleet's policy where a host's own still answered
kristofferR 74860c6
Let a policy read stand only where it still decides the same thing
kristofferR dc2ba51
Refuse a scope login GitHub could never issue
kristofferR 65bfa83
Merge origin/main into feat/fleet-config
kristofferR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.