crq follow-up: findings from c05444d's review (post-merge) by kristofferR · Pull Request #7 · kristofferR/coderabbit-queue

kristofferR · 2026-06-23T02:57:21Z

Addresses the Codex review of c05444d that landed after PR #6 merged (I called convergence too early): crq:472, crq:1009, monitor:55, README:301. Diff = those fixes on top of the merged code. Known/declined: the no-CAS leader items (#4).

Summary by CodeRabbit

Bug Fixes
- Improved “new feedback” detection by considering bot comment updates (not just newly created comments), so edits are treated as new signals.
- Updated rate-limit WARNING matching to prioritize the most recently updated pull request when multiple matches exist.
- Prevented redundant --no-incremental reviews by also recognizing the completion marker in the pull request description.
Documentation
- Refreshed the review-loop README example to align with the improved new-feedback detection behavior.

I called convergence before Codex re-reviewed the last commit; it found 4 valid items: - _warning_latest: --sort updated so the bounded scan probes the most-recently-active PRs, not an arbitrary best-match slice, before the cap (crq:472) - autoreview --no-incremental: also check the PR DESCRIPTION for CodeRabbit's summary (its default location), not just issue comments, before deciding a PR is unreviewed (crq:1009) - examples/monitor.sh: bot_count emits 'count@latest-timestamp' so an EDITED summary/walkthrough (count unchanged) still changes the signature and wakes the loop (monitor:55) - README sample loop: poll updated_at (// created_at) so an edited bot comment isn't missed (README:301) Ref #6 Claude-Session: https://claude.ai/code/session_01QVnKpFmFMYvRTyeoYozXst

coderabbitai · 2026-06-23T02:57:28Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 907a9fe1-c7d6-4e09-b2ba-a66c271ff91b

📥 Commits

Reviewing files that changed from the base of the PR and between 862f3b8 and bf7f4cf.

📒 Files selected for processing (1)

crq

📜 Recent review details

🔇 Additional comments (1)

crq (1)

945-945: LGTM!

Also applies to: 1011-1016

📝 Walkthrough

Walkthrough

Three small logic fixes improve bot-activity detection: crq's _warning_latest adds --sort updated to its PR search, cmd_autoreview --no-incremental now also scans the PR description body for CRQ_REVIEW_DONE_MARKER, examples/monitor.sh returns a composite count@timestamp wake-signature, and the README example switches to updated_at // created_at for comment freshness.

Changes

Bot feedback freshness and reviewed-marker detection

Layer / File(s)	Summary
Rate-limit warning scan sort order `crq`	`_warning_latest` now passes `--sort updated` to `gh search prs`, changing the ordering used to pick the most-recent warning-derived reset candidate.
No-incremental reviewed-marker body check `crq`	In `cmd_autoreview`'s `--no-incremental` branch, after the comment-based scan, the PR description body is also checked for `CRQ_REVIEW_DONE_MARKER`; if found, `reviewed=1` is set to skip redundant enqueue.
monitor.sh composite wake-signature `examples/monitor.sh`	`bot_count`'s jq filter now returns `length@max(updated_at/submitted_at)` instead of a plain count, so edits to existing bot comments (same count, changed timestamp) also trigger `NEW_FEEDBACK`.
README review-loop freshness signal `README.md`	The `jq` selector in the `review-loop.sh` example uses `(.updated_at // .created_at)` as the freshness timestamp instead of only `.created_at`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

kristofferR/coderabbit-queue#1: Introduces the core crq implementation containing _warning_latest and cmd_autoreview, the exact functions modified here.
kristofferR/coderabbit-queue#6: Rewrites autoreview rate-limit handling and completion-marker logic in crq, directly overlapping with the _warning_latest ordering and no-incremental marker detection changes in this PR.

Poem

🐇 A timestamp updated, a body now scanned,
The sort order shifted, the markers well-planned.
updated_at whispers: "This comment was changed!"
The queue finds the marker wherever it ranged.
No redundant reviews — the bunny is pleased! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title references a specific prior commit review (`c05444d`) and indicates this is a follow-up addressing findings from that review, which aligns with the PR's actual purpose of fixing issues identified post-merge.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch review

_{Comment @coderabbitai help to get the list of available commands.}

kristofferR · 2026-06-23T02:57:56Z

@codex review

kristofferR · 2026-06-23T02:59:03Z

@coderabbitai review

coderabbitai · 2026-06-23T02:59:09Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Line 301: The jq filter on line 301 of README.md that checks for rate-limited
comments is not resilient to edge cases encountered at runtime. Modify the
filter to defensively handle null or missing body fields by adding a
null-coalescing operator before the contains check, and update the rate-limit
marker detection to handle case-variance by converting the body to lowercase
before checking if it contains the rate-limit indicator (rather than doing a
case-sensitive match on "rate limited by coderabbit.ai"). This ensures the
filter works correctly with all payload variations without erroring or
miscounting results.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c97d984b-fe0a-4d1a-9e29-18c6a778bb7b

📥 Commits

Reviewing files that changed from the base of the PR and between 460d18d and 124fba9.

📒 Files selected for processing (3)

README.md
crq
examples/monitor.sh

📜 Review details

🧰 Additional context used

🪛 Shellcheck (0.11.0)

examples/monitor.sh

[info] 36-36: Expressions don't expand in single quotes, use double quotes for that.

(SC2016)

🔇 Additional comments (2)

crq (1)

472-472: LGTM!

Also applies to: 1010-1012

examples/monitor.sh (1)

34-39: LGTM!

…ate-limit marker (README:301) Match the runtime/example behavior so a copied loop can't miscount or error on null bodies or marker case-variance. Ref #7 Claude-Session: https://claude.ai/code/session_01QVnKpFmFMYvRTyeoYozXst

kristofferR · 2026-06-23T03:04:20Z

@codex review

kristofferR · 2026-06-23T03:05:40Z

@coderabbitai review

coderabbitai · 2026-06-23T03:05:46Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 862f3b8ec0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…crq:1012) Follow-on of crq:1009: if 'gh api pulls/$pr --jq .body' fails transiently, don't fall through to enqueue on an unknown — skip the PR (same guard as the comments lookup, crq:972). Ref #7 Claude-Session: https://claude.ai/code/session_01QVnKpFmFMYvRTyeoYozXst

kristofferR · 2026-06-23T03:11:44Z

@codex review

kristofferR · 2026-06-23T03:13:28Z

@coderabbitai review

coderabbitai · 2026-06-23T03:13:34Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

chatgpt-codex-connector · 2026-06-23T03:17:45Z

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: bf7f4cf3ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

coderabbitai Bot reviewed Jun 23, 2026

View reviewed changes

Comment thread README.md Outdated

chatgpt-codex-connector Bot reviewed Jun 23, 2026

View reviewed changes

Comment thread crq Outdated

kristofferR merged commit 7e848e4 into review-base Jun 23, 2026
1 check passed

kristofferR deleted the review branch June 23, 2026 11:39

coderabbitai Bot mentioned this pull request Jun 29, 2026

Rewrite crq as a Go CLI #10

Merged

coderabbitai Bot mentioned this pull request Jul 17, 2026

Replace the patchwork core with a round state machine, bot dialects, and a pure decision engine #30

Merged

Conversation

kristofferR commented Jun 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

kristofferR commented Jun 23, 2026

Uh oh!

kristofferR commented Jun 23, 2026

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kristofferR commented Jun 23, 2026

Uh oh!

kristofferR commented Jun 23, 2026

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

kristofferR commented Jun 23, 2026

Uh oh!

kristofferR commented Jun 23, 2026

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Jun 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kristofferR commented Jun 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading