fix: add secret directory, fix typo, bump node image to 2.4.0#3
Open
fix: add secret directory, fix typo, bump node image to 2.4.0#3
Conversation
0bfa113 to
029d62f
Compare
Contributor
Author
|
Note: The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secret/andsecret/keystore/are bind-mounted by all docker-compose files but were absent from the repo, causing containers to fail on first run after a fresh cloneserect→secretacross all volume mounts, entrypoint scripts, READMEs, and.gitignore(mainnet & testnet)docker compose upwith no mention of the required directory creationbitkubchainorg/nodefrom2.3.0to2.4.0in all six docker-compose filesChanges
serect/→secret/in all compose files, entrypoint scripts, READMEs, and.gitignorefor bothmainnet/andtestnet/secret/.gitkeepandsecret/keystore/.gitkeepso the required directory structure exists after a fresh clone.gitignoreto track the empty directory structure while still ignoring actual secret files (password, keystore JSON)mkdir -p secret/keystorestep2.3.0→2.4.0in all six docker-compose files (mainnet + testnet: fullnode, validator, archivenode)Test plan
cd mainnet→docker compose -f docker-compose.fullnode.yaml up -dstarts without bind-mount errorssecret/password.txtand keystore files generated at runtime are still gitignored🤖 Generated with Claude Code