Update generated client to Kubernetes v1.36 (SDK 20.0) - #1733
Merged
Conversation
Agent-Logs-Url: https://github.com/kubernetes-client/csharp/sessions/d2ac4cd1-9e42-4381-9654-047665dcbe93 Co-authored-by: tg123 <170430+tg123@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
tg123
April 24, 2026 09:14
View session
tg123
marked this pull request as ready for review
April 25, 2026 05:38
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Kubernetes C# client generation inputs and project metadata to align with the Kubernetes v1.36 API surface and bump the SDK major version to 20.0.
Changes:
- Bump SDK version to
20.0via Nerdbank.GitVersioning (version.json). - Update generation target to
KUBERNETES_BRANCH=v1.36.0(csharp.settings). - Extend the README compatibility matrix with the
20.0 / 1.36entry.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| version.json | Raises SDK version to 20.0 for the v1.36 client generation release. |
| csharp.settings | Points the generator at Kubernetes v1.36.0. |
| README.md | Adds the 20.0 / 1.36 row to the version compatibility table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, Copilot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks the upstream v1.36 API surface and bumps the SDK accordingly (refs #1712).
csharp.settings→KUBERNETES_BRANCH=v1.36.0.swagger.jsonregenerated from the processed v1.36 spec (info.versionis nowv1.36.0).version.jsonraised to20.0; README compatibility table extended with the20.0 / 1.36row.Generator caveat
swagger.jsonwas regenerated usingkubernetes-client/gen'sopenapi/preprocess_spec.pypinned to commitdde176f— the same generator state used for the v1.35 PR (#1712).A more recent gen change (commit
71843ee) unconditionally injectsapidiscovery.k8s.io/v2{,beta1}definitions whose$refs point toio.k8s.apimachinery.pkg.apis.meta.v1.GroupVersionKind. That type is no longer present in the upstream v1.36 OpenAPI spec, leaving dangling refs that causeKubernetesClientSourceGeneratorto fail to initialize:Pinning the gen revision sidesteps this; a follow-up in
kubernetes-client/genshould fix the dangling ref before adopting newer gen revisions here.