Skip to content

Update generated client to Kubernetes v1.36 (SDK 20.0) - #1733

Merged
k8s-ci-robot merged 1 commit into
masterfrom
copilot/update-spec-to-1-36
Apr 25, 2026
Merged

Update generated client to Kubernetes v1.36 (SDK 20.0)#1733
k8s-ci-robot merged 1 commit into
masterfrom
copilot/update-spec-to-1-36

Conversation

Copilot AI commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Tracks the upstream v1.36 API surface and bumps the SDK accordingly (refs #1712).

  • Generation inputs: csharp.settingsKUBERNETES_BRANCH=v1.36.0.
  • Generated artifacts: swagger.json regenerated from the processed v1.36 spec (info.version is now v1.36.0).
  • Versioning & docs: version.json raised to 20.0; README compatibility table extended with the 20.0 / 1.36 row.

Generator caveat

swagger.json was regenerated using kubernetes-client/gen's openapi/preprocess_spec.py pinned to commit dde176f — the same generator state used for the v1.35 PR (#1712).

A more recent gen change (commit 71843ee) unconditionally injects apidiscovery.k8s.io/v2{,beta1} definitions whose $refs point to io.k8s.apimachinery.pkg.apis.meta.v1.GroupVersionKind. That type is no longer present in the upstream v1.36 OpenAPI spec, leaving dangling refs that cause KubernetesClientSourceGenerator to fail to initialize:

warning CS8784: Generator 'KubernetesClientSourceGenerator' failed to initialize.
  ... 'Could not resolve the path
        '#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.GroupVersionKind'.'

Pinning the gen revision sidesteps this; a follow-up in kubernetes-client/gen should fix the dangling ref before adopting newer gen revisions here.

Copilot AI self-assigned this Apr 24, 2026
Copilot AI review requested due to automatic review settings April 24, 2026 09:14
Copilot AI removed the request for review from Copilot April 24, 2026 09:14
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 24, 2026
@tg123
tg123 marked this pull request as ready for review April 25, 2026 05:38
Copilot AI review requested due to automatic review settings April 25, 2026 05:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Kubernetes C# client generation inputs and project metadata to align with the Kubernetes v1.36 API surface and bump the SDK major version to 20.0.

Changes:

  • Bump SDK version to 20.0 via Nerdbank.GitVersioning (version.json).
  • Update generation target to KUBERNETES_BRANCH=v1.36.0 (csharp.settings).
  • Extend the README compatibility matrix with the 20.0 / 1.36 entry.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
version.json Raises SDK version to 20.0 for the v1.36 client generation release.
csharp.settings Points the generator at Kubernetes v1.36.0.
README.md Adds the 20.0 / 1.36 row to the version compatibility table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@brendandburns

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Copilot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2026
@k8s-ci-robot
k8s-ci-robot merged commit b4a4f56 into master Apr 25, 2026
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants