Passing `follow=True` to `read_namespaced_pod_log` makes it never return

[yuvipanda]

I'm trying to stream logs out of a running pod.

For a pod named 'test' running in the default namespace,

api = client.CoreV1Api()
api.read_namespaced_pod_log("test", "default")

returns the logs so far. But,

api = client.CoreV1Api()
api.read_namespaced_pod_log("test", "default", follow=True)

just never returns. I can't use it with watch.Watch either since that seems to be for a very different purpose.

[yuvipanda]

It looks like I can pass _preload_content=False and get a stream that works - however this is unituitive and doesn't seem documented in the obvious places.

[mbohlool]

Maybe we can add a follow method to Watch class to set "follow" flag instead of "watch" and stream out strings instead of API objects. but _preload_content need to be documented anyway.

[yuvipanda]

+1 on adding it to Watch (or watch could special case this one?)

…

On Wed, May 3, 2017 at 11:26 AM, Mehdy Bohlool ***@***.***> wrote: Maybe we can add a follow method to Watch class to set "follow" flag instead of "watch" and stream out strings instead of API objects. but _preload_content need to be documented anyway. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#199 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB23vyGNN2NrMePmgLy81a5qAVLm70Rks5r2Ma9gaJpZM4NIDE6> .

-- Yuvi Panda T http://yuvi.in/blog

[mbohlool]

I am just looking for somebody to do this. If nobody took it and I got free time (maybe not near future :) ), I will do it.

[mbohlool]

Watch class can also use inspect.getargspec to see if there is Watch or Follow parameter and then stream the result accordingly.

[kayibal]

@mbohlool Any update on this? I'd be happy to contribute but would need a few sentences as guideline.

[mbohlool]

It would be nice if you can contribute. Here are the things need to be done:

• _preload_content need to be documented somewhere
• Add a section to Watch class to use inspect.getargspec or some other methods to determine if the passed function has Watch or Follow flag and set the appropriate flag.
• Test this on read_namespaced_pod_log to see if it is working. The return type should be set to string if it is not already that (look like read_namespaced_pod_log return type is str so we should be fine there).

Let me know if you need more. I will be happy to review the code when it is ready.

[hackenzheng]

I added "_preload_content=False" based on the official example , it still has no output. How can i get the the stream output

[mitar]

FYI, read_namespaced_pod_log(self, name, namespace, **kwargs) is the signature of the function, so one cannot really use inspect to see if the function is taking watch or follow.