Skip to content

fix: mount stuck issue#862

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
umagnus:use_util_wait_func
Nov 14, 2024
Merged

fix: mount stuck issue#862
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
umagnus:use_util_wait_func

Conversation

@umagnus
Copy link
Copy Markdown
Contributor

@umagnus umagnus commented Nov 14, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

cleanup: use util wait function instead of wait package which can't use in exec command, referring to kubernetes-sigs/blob-csi-driver#1278

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 14, 2024

Hi @umagnus. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2024
andyzhangx
andyzhangx reviewed Nov 14, 2024
View reviewed changes
Comment thread pkg/util/util.go Outdated
done := make(chan bool)
var err error

// Start the azcopy exec function in a goroutine
Copy link
Copy Markdown
Member

@andyzhangx andyzhangx Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove azcopy word

Copy link
Copy Markdown
Contributor Author

@umagnus umagnus Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread pkg/util/util.go Outdated

// WaitUntilTimeout waits for the exec function to complete or return timeout error
func WaitUntilTimeout(timeout time.Duration, execFunc ExecFunc, timeoutFunc TimeoutFunc) error {
// Create a channel to receive the result of the azcopy exec function
Copy link
Copy Markdown
Member

@andyzhangx andyzhangx Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove azcopy word

Copy link
Copy Markdown
Contributor Author

@umagnus umagnus Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11834002355

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 79.643%
Totals Coverage Status
Change from base Build 11724702630: 0.3%
Covered Lines: 1025
Relevant Lines: 1287
💛 - Coveralls

@andyzhangx andyzhangx changed the title cleanup: use util wait function fix: mount stuck issue Nov 14, 2024
@andyzhangx
Copy link
Copy Markdown
Member

andyzhangx commented Nov 14, 2024

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 14, 2024
andyzhangx
andyzhangx reviewed Nov 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2024
@andyzhangx
Copy link
Copy Markdown
Member

andyzhangx commented Nov 14, 2024

/retest

andyzhangx
andyzhangx approved these changes Nov 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, umagnus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3d4721a into kubernetes-csi:master Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@umagnus @k8s-ci-robot @coveralls @andyzhangx