Add nil check for groupSnapshotContent in deleteCSIGroupSnapshotOperaion and unit tests#1152
Conversation
|
Hi @manishym. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest |
|
Can you please rebase? |
5f04b1b to
9752e2a
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manishym, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@manishym can you please rebase the PR |
…tion and unit tests - Add a check to ensure `groupSnapshotContent` is not nil in `deleteCSIGroupSnapshotOperation` to prevent panics. - Enhance error handling for missing `SnapshotHandle` in `VolumeSnapshotContent` objects during deletion. - Create initial unit tests in `groupsnapshot_helper_test.go` to cover cases where `groupSnapshotContent` is nil or incomplete. Signed-off-by: Manish <myathnal@redhat.com>
9752e2a to
a1074f5
Compare
|
/lgtm |
groupSnapshotContentis not nil indeleteCSIGroupSnapshotOperationto prevent panics.SnapshotHandleinVolumeSnapshotContentobjects during deletion.groupsnapshot_helper_test.goto cover cases wheregroupSnapshotContentis nil or incomplete.What type of PR is this?
What this PR does / why we need it:
Before fix:
After fix:
Which issue(s) this PR fixes:
Fixes #1123
Special notes for your reviewer:
Does this PR introduce a user-facing change?: