fix: Stop StatusWatcher on Forbidden API error#585
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom May 17, 2022
Merged
fix: Stop StatusWatcher on Forbidden API error#585k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
karlkfi
force-pushed
the
karl-watch-perm-error
branch
from
2d3c932 to
e7dc126
Compare
This was referenced May 17, 2022
karlkfi
force-pushed
the
karl-watch-perm-error
branch
from
e7dc126 to
669f498
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
janetkuo
reviewed
May 17, 2022
- This matches previous StatusPoller behavior which would error and exit if there was a 403 Forbidden error from the apiserver. - Handle status error before synchronization with immediate exit
karlkfi
force-pushed
the
karl-watch-perm-error
branch
from
669f498 to
57bbe71
Compare
k8s-ci-robot
removed
the
lgtm
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi, Liujingfang1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and exit if there was a 403 Forbidden error from the apiserver.
Without this fix, the StatusWatcher gets stuck in an endless retry loop until cancelled or permission is granted, printing the following warning: