add filtering and listing functionalities#605
add filtering and listing functionalities#605k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @chunglu-chou. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/L
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
chunglu-chou
force-pushed
the
migrate
branch
4 times, most recently
from
24f3b94 to
097a477
Compare
mortent
left a comment
mortent
left a comment
There was a problem hiding this comment.
Just a few small comments, but overall looks good.
cmd/status/cmdstatus.go
Outdated
| import ( | ||
| "context" | ||
| "fmt" | ||
| ss "strings" |
There was a problem hiding this comment.
Lets avoid aliasing the go libraries. If there is a conflict, use an alias for the other library
cmd/status/cmdstatus.go
Outdated
| func (r *Runner) runE(cmd *cobra.Command, args []string) error { | ||
| func (r *Runner) preRunE(*cobra.Command, []string) error { | ||
| if !slice.ContainsString(PollUntilOptions, r.pollUntil, nil) { | ||
| return fmt.Errorf("pollUntil must be one of %s, %s, %s, %s", |
There was a problem hiding this comment.
Nit: I think it would be easier to just use strings.Join(PollUntilOptions, ",") here
cmd/status/cmdstatus.go
Outdated
| switch r.invType { | ||
| case Local: | ||
| if len(args) != 0 { | ||
| fmt.Printf("%c[%dm", printcommon.ESC, printcommon.YELLOW) |
There was a problem hiding this comment.
I think you can simplify this with:
cli-utils/pkg/print/common/color.go
Line 25 in eb8ebd7
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chunglu-chou, mortent The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 participants
Add filter options on inventory names, namespaces, and statuses.
Add functions for retrieving a list of live inventory objects from the cluster.