fix: retain objects which failed to reconcile#623
fix: retain objects which failed to reconcile#623k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
|
Hi @sdowell. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This change is based on #622 |
|
/assign @karlkfi |
|
/ok-to-test |
|
/retest |
415724e to
9645a6b
Compare
|
/test cli-utils-presubmit-master-stress |
9645a6b to
709854f
Compare
709854f to
d78beb7
Compare
This change updates the set-inventory logic to retain objects which failed to reconcile. This ensures that if you run the applier/destroyer multiple times, an object that is failing to reconcile will be retained in the inventory. Before this change, an object failing to reconcile could be lost after multiple attempts (e.g. multiple destroys).
d78beb7 to
cd911bf
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi, sdowell The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change updates the set-inventory logic to retain objects which
failed to reconcile. This ensures that if you run the applier/destroyer
multiple times, an object that is failing to reconcile will be retained
in the inventory. Before this change, an object failing to reconcile
could be lost after multiple attempts (e.g. multiple destroys).