e2e: restore secret name to original while running tests with ToxiProxy #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
cncf-cla: yes
Collaborator
Author
|
/test all |
|
Test Results : (tid-29) |
|
Test Results : (tid-30) |
|
Test Results : (tid-31) |
|
Test Results : (tid-32) |
|
Test Results : (tid-34) |
|
Test Results : (tid-23) |
|
Test Results : (tid-24) |
The e2e test network_interruption_toxi.go failed with message below, which is because the default secretname has been updated to secret1-toxiproxy in deploy_app_toxi.go.
09:09:18 ␛[91mExpected
09:09:18 <*errors.StatusError | 0xc00095b9a0>: {
09:09:18 ErrStatus: {
09:09:18 TypeMeta: {Kind: "", APIVersion: ""},
09:09:18 ListMeta: {
09:09:18 SelfLink: "",
09:09:18 ResourceVersion: "",
09:09:18 Continue: "",
09:09:18 RemainingItemCount: nil,
09:09:18 },
09:09:18 Status: "Failure",
09:09:18 Message: "secrets \"secret1-toxiproxy\" not found",
09:09:18 Reason: "NotFound",
09:09:18 Details: {
09:09:18 Name: "secret1-toxiproxy",
09:09:18 Group: "",
09:09:18 Kind: "secrets",
09:09:18 UID: "",
09:09:18 Causes: nil,
09:09:18 RetryAfterSeconds: 0,
09:09:18 },
09:09:18 Code: 404,
09:09:18 },
09:09:18 }
09:09:18 to be nil␛[0m
This happened with deploy_app_toxi.go sometimes, if network_interruption_toxi.go is run before it.
weizhouapache
force-pushed
the
e2e-fix-network_interruption_toxi
branch
from
1a47ea4 to
7b0ef7a
Compare
weizhouapache
changed the title
|
Tests were aborted. |
|
Test Results : (tid-36) |
|
Test Results : (tid-37) |
|
Test Results : (tid-38) |
|
Tests were aborted. |
Collaborator
Author
|
/run-e2e -c 4.18 -h vmware |
|
@weizhouapache a jenkins job has been kicked to run test with following paramaters:
|
Collaborator
Author
|
/run-e2e -c 4.18 -h xen |
|
@weizhouapache a jenkins job has been kicked to run test with following paramaters:
|
|
Tests were aborted. |
|
@weizhouapache a jenkins job has been kicked to run test with following paramaters:
|
|
@weizhouapache a jenkins job has been kicked to run test with following paramaters:
|
|
Tests were aborted. |
Collaborator
Author
|
/run-e2e help |
|
@weizhouapache Usage: /run-e2e [-k Kubernetes_Version] [-c CloudStack_Version] [-h Hypervisor] [-i Template/Image] [-f Kubernetes_Version_Upgrade_From] [-t Kubernetes_Version_Upgrade_To]
Examples:
|
|
Test Results : (tid-40) |
|
Test Results : (tid-33) |
|
Tests were aborted. |
|
Test Results : (tid-35) |
|
Tests were aborted. |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
|
/approve |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rohityadavcloud, weizhouapache The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Test Results : (tid-38) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The e2e test network_interruption_toxi.go failed with message below
The issue is because the default secretname has been updated to secret1-toxiproxy in deploy_app_toxi.go.
This happened with deploy_app_toxi.go sometimes, if network_interruption_toxi.go is run before it.
Description of changes:
Issue should be fixed by restoring secret name to original
Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.