✨ switch light workflows to ubuntu-slim runner#3082
✨ switch light workflows to ubuntu-slim runner#3082Deepak8858 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @Deepak8858! |
|
Hi @Deepak8858. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
lentzi90
left a comment
There was a problem hiding this comment.
Thanks for the PR!
The changes looks good, however there are a few failing checks that we will need to address. Could you check the CLA failure? We need all contributors to sign the CLA before we can accept contributions.
Please also update the commit message to avoid directly referencing the issue it solves. Just mention what is changed instead.
|
Oh one more finding. It seems like the zizmor workflow cannot run on ubuntu-slim. It requires docker socket access. Please put that one back on ubuntu-latest. |
|
/retitle ✨ switch light workflows to ubuntu-slim runner |
|
Keywords which can automatically close issues and hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
As per the issue description, some GitHub workflows do not require much resources and can be switched to the
ubuntu-slimrunner to save resources.Modified workflows:
Closes #3079