🌱 Add regression test for security group failure on previously ready cluster#3104
Conversation
…iously ready cluster Add a regression test for the scenario described in kubernetes-sigs#2993 where a cluster that was already Ready would not show as failed when security group reconciliation fails on a subsequent reconcile. The test pre-sets ReadyCondition=True, SecurityGroupsReadyCondition=True, and NetworkReadyCondition=True to simulate a previously successful reconcile, then triggers a security group failure and verifies that: - ReadyCondition flips to False - SecurityGroupsReadyCondition flips to False - NetworkReadyCondition remains True (network succeeded) This complements the existing test which only covers the fresh cluster scenario (no prior conditions set). Ref: kubernetes-sigs#2993 Signed-off-by: Dong Ma <winterma.dong@gmail.com>
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/L
|
Hi @larainema. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/retest-required |
|
/retest |
1 similar comment
|
/retest |
3 participants
What this PR does
Adds a regression test for the scenario described in #2993: a cluster that was already
Readyshould properly clear itsReadyConditionwhen security group reconciliation fails on a subsequent reconcile.Why
The existing test (
should set SecurityGroupsReadyCondition to False when security group reconciliation fails) only covers the fresh cluster scenario where no prior conditions are set. It doesn't validate the more critical regression scenario from #2993 where:SecurityGroupRuleExistsconflict)How
The test pre-sets
ReadyCondition=True,SecurityGroupsReadyCondition=True, andNetworkReadyCondition=Trueto simulate a previously successful reconcile, then triggers a security group failure and verifies:ReadyConditionflips toFalse(viahandleUpdateOSCError)SecurityGroupsReadyConditionflips toFalsewith reasonSecurityGroupCreateFailedNetworkReadyConditionremainsTrue(network reconciliation succeeded)Ref #2993