Skip to content

remove unused random source seeding property#294

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
matrus2:rand
Jul 17, 2023
Merged

remove unused random source seeding property#294
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
matrus2:rand

Conversation

@matrus2
Copy link
Contributor

@matrus2 matrus2 commented Jul 7, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 7, 2023
@k8s-ci-robot k8s-ci-robot requested a review from cpanato July 7, 2023 14:24
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 7, 2023

Hi @matrus2. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2023
@harshanarayana
Copy link
Contributor

harshanarayana commented Jul 8, 2023

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@matrus2 mind fixing your commit message?

@harshanarayana
Copy link
Contributor

harshanarayana commented Jul 8, 2023

/retitle remove unused random source seeding property

@k8s-ci-robot k8s-ci-robot changed the title Remove unused property fixes #290 remove unused random source seeding property Jul 8, 2023
phisco
phisco approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 9, 2023

@phisco: changing LGTM is restricted to collaborators

Details

In response to this:

thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShwethaKumbla
Copy link
Member

ShwethaKumbla commented Jul 10, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2023
@harshanarayana
Copy link
Contributor

harshanarayana commented Jul 15, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 15, 2023
@harshanarayana
Copy link
Contributor

harshanarayana commented Jul 15, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2023
@harshanarayana
Copy link
Contributor

harshanarayana commented Jul 15, 2023

@matrus2 Can you please fix the commit message to remove the unsupported special characters ? We can get that one merged if that is done.

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Jul 17, 2023
@matrus2
Copy link
Contributor Author

matrus2 commented Jul 17, 2023

@harshanarayana Fixed, thanks.

cpanato
cpanato approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@harshanarayana
Copy link
Contributor

harshanarayana commented Jul 17, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, harshanarayana, matrus2, phisco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshanarayana
Copy link
Contributor

harshanarayana commented Jul 17, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit a2fe06b into kubernetes-sigs:main Jul 17, 2023
@harshanarayana harshanarayana mentioned this pull request Aug 14, 2023
Closed
@matrus2 matrus2 mentioned this pull request Oct 27, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpanato cpanato cpanato approved these changes

@harshanarayana harshanarayana Awaiting requested review from harshanarayana

+1 more reviewer

@phisco phisco phisco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harshanarayana harshanarayana

@cpanato cpanato

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matrus2 @k8s-ci-robot @harshanarayana @ShwethaKumbla @cpanato @phisco