Skip to content

🌱 Add experimental package and shared cache & informer implementation#128

Open
mjudeikis wants to merge 3 commits intokubernetes-sigs:mainfrom
mjudeikis:cluster.aware.informer
Open

🌱 Add experimental package and shared cache & informer implementation#128
mjudeikis wants to merge 3 commits intokubernetes-sigs:mainfrom
mjudeikis:cluster.aware.informer

Conversation

@mjudeikis
Copy link
Copy Markdown
Collaborator

This PR goes a bit wild. This is an experimental package (/exp) and an example that implements a shared cache & informer for use with multicluster-runtime.

The benefit is that we enable memory and cross-cluster queries for the reconciler (see exp-kind-shared-cache).

In a way, this is currently not possible to be built using upstream client-go packages due to hardcoded KeyFunc usage (it's strange why we have those but we can't use them as they are not exposed :) )

90% of the code here is copied from the client-go tooling for informers and cache.

This is, in a way, idea seeding effort to see if people would find this useful

On-behalf-of: SAP <mangirdas.judeikis@sap.com>
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from embik and sttts January 30, 2026 09:56
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2026
@mjudeikis
Copy link
Copy Markdown
Collaborator Author

@sttts gentle reminder :)

@embik
Copy link
Copy Markdown
Member

embik commented Mar 7, 2026

I'm not sure I like this being in an exp package, even though I understand the intention. If we ever "graduate" this, we will effectively break updates for projects already importing it. It will look like there is no newer version available, and devs will manually figure out it moved places.

I would be more in favor of putting sufficient module-level and maybe even function/struct-level doc strings on this marking it as an experimental package under a permanent package path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants