Replace autorest/to with k8s.io/utils/ptr by mboersma · Pull Request #8723 · kubernetes/autoscaler

mboersma · 2025-10-31T16:53:30Z

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Replaces usages of the deprecated github.com/Azure/go-autorest/autorest/to package with k8s.io/utils/ptr.

Which issue(s) this PR fixes:

Refs #8145.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

jackfrancis · 2025-10-31T16:55:29Z

cluster-autoscaler/go.mod

 	github.com/Azure/go-autorest/autorest/adal v0.9.24
 	github.com/Azure/go-autorest/autorest/azure/auth v0.5.13
 	github.com/Azure/go-autorest/autorest/date v0.3.0
-	github.com/Azure/go-autorest/autorest/to v0.4.0


jackfrancis · 2025-10-31T17:29:25Z

cluster-autoscaler/cloudprovider/azure/azure_cache.go

-		if vmPoolName == nil {
-			continue
+		if vmPoolName != nil {
+			instances[*vmPoolName] = append(instances[*vmPoolName], instance)


cluster-autoscaler/cloudprovider/azure/azure_scale_set_test.go

jackfrancis · 2025-10-31T17:37:10Z

cluster-autoscaler/cloudprovider/azure/azure_vms_pool.go

+			strings.EqualFold(ptr.Deref(manualProfile.Sizes[0], ""), vmSku) {
 			klog.V(5).Infof("Found matching manual profile for VM SKU: %s, updating count to: %d", vmSku, count)
-			manualProfile.Count = to.Int32Ptr(count)
+			manualProfile.Count = ptr.To(count)


fwiw reading over this is what made me think we don't need to to cast if the inputted variable already fulfills the type requirement (the output from ptr.To will match that same type)

I updated the PR to remove the two optional casts to [int64].

jackfrancis

left some nit feedback for a few items

jackfrancis

/lgtm
/approve

jackfrancis

/lgtm
/approve

k8s-ci-robot · 2025-10-31T20:53:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~cluster-autoscaler/OWNERS~~ [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jackfrancis · 2025-10-31T22:01:01Z

/cherry-pick cluster-autoscaler-release-1.34

k8s-infra-cherrypick-robot · 2025-10-31T22:01:39Z

@jackfrancis: new pull request created: #8730

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jackfrancis · 2025-10-31T22:01:53Z

/cherry-pick cluster-autoscaler-release-1.33

k8s-infra-cherrypick-robot · 2025-10-31T22:02:31Z

@jackfrancis: new pull request created: #8731

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jackfrancis · 2025-10-31T22:04:46Z

/cherry-pick cluster-autoscaler-release-1.32

k8s-infra-cherrypick-robot · 2025-10-31T22:05:22Z

@jackfrancis: #8723 failed to apply on top of branch "cluster-autoscaler-release-1.32":

Applying: Replace autorest/to with k8s.io/utils/ptr
Using index info to reconstruct a base tree...
M	cluster-autoscaler/cloudprovider/azure/azure_vms_pool.go
M	cluster-autoscaler/go.mod
Falling back to patching base and 3-way merge...
Auto-merging cluster-autoscaler/go.mod
CONFLICT (content): Merge conflict in cluster-autoscaler/go.mod
Auto-merging cluster-autoscaler/cloudprovider/azure/azure_vms_pool.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Replace autorest/to with k8s.io/utils/ptr

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot requested review from elmiko and jackfrancis October 31, 2025 16:53

k8s-ci-robot added area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-area labels Oct 31, 2025

jackfrancis reviewed Oct 31, 2025

View reviewed changes

cluster-autoscaler/cloudprovider/azure/azure_scale_set_test.go Outdated Show resolved Hide resolved

jackfrancis reviewed Oct 31, 2025

View reviewed changes

mboersma force-pushed the go-autorest-deprecated branch from 72753c2 to c6ecc43 Compare October 31, 2025 17:41

jackfrancis approved these changes Oct 31, 2025

View reviewed changes

k8s-ci-robot assigned jackfrancis Oct 31, 2025

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2025

mboersma force-pushed the go-autorest-deprecated branch from c6ecc43 to 3c9e7b6 Compare October 31, 2025 20:39

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025

Replace autorest/to with k8s.io/utils/ptr

f28ee6e

mboersma force-pushed the go-autorest-deprecated branch from 3c9e7b6 to f28ee6e Compare October 31, 2025 20:45

jackfrancis approved these changes Oct 31, 2025

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025

k8s-ci-robot merged commit f7fc231 into kubernetes:master Oct 31, 2025
8 of 9 checks passed

mboersma deleted the go-autorest-deprecated branch October 31, 2025 21:08

k8s-infra-cherrypick-robot mentioned this pull request Oct 31, 2025

[cluster-autoscaler-release-1.34] Replace autorest/to with k8s.io/utils/ptr #8730

Merged

k8s-infra-cherrypick-robot mentioned this pull request Oct 31, 2025

[cluster-autoscaler-release-1.33] Replace autorest/to with k8s.io/utils/ptr #8731

Merged

Conversation

mboersma commented Oct 31, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

jackfrancis Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

jackfrancis Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jackfrancis Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

mboersma Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

jackfrancis left a comment

Choose a reason for hiding this comment

Uh oh!

jackfrancis left a comment

Choose a reason for hiding this comment

Uh oh!

jackfrancis left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Oct 31, 2025

Uh oh!

Uh oh!

jackfrancis commented Oct 31, 2025

Uh oh!

k8s-infra-cherrypick-robot commented Oct 31, 2025

Uh oh!

jackfrancis commented Oct 31, 2025

Uh oh!

k8s-infra-cherrypick-robot commented Oct 31, 2025

Uh oh!

jackfrancis commented Oct 31, 2025

Uh oh!

k8s-infra-cherrypick-robot commented Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants