Skip to content

drop mailru/easyjson by upgrading go-openapi/swag to v0.25.4#590

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
dims:drop-easyjson
May 2, 2026
Merged

drop mailru/easyjson by upgrading go-openapi/swag to v0.25.4#590
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
dims:drop-easyjson

Conversation

@dims
Copy link
Copy Markdown
Member

@dims dims commented Apr 26, 2026

go-openapi/swag v0.25.4 refactored into sub-modules that no longer depend on github.com/mailru/easyjson. The root package re-exports all the same symbols so no import changes are needed.

The go directive bumps to 1.24.0 (required by swag sub-modules), which also surfaces two pre-existing vet errors (non-constant format strings) fixed here.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 26, 2026
@dims
Copy link
Copy Markdown
Member Author

dims commented Apr 26, 2026

/assign @Jefftree @apelisse

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2026
@dims
Copy link
Copy Markdown
Member Author

dims commented Apr 26, 2026

/assign @jpbetz @sttts

@jpbetz
Copy link
Copy Markdown
Contributor

jpbetz commented Apr 26, 2026

/approve
/lgtm

Excellent. Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2026
@dims
Copy link
Copy Markdown
Member Author

dims commented Apr 26, 2026

looks like we need explicit approvals from

/assign @sttts @liggitt

(thanks @jpbetz!)

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Apr 27, 2026

@dims how deep have you looked into potential behaviour changes? go-openapi has some reputation of changing semantics without notification by accident. As we use it in our CRD validation there is risk that we break our API (we have forked the go-openapi validator nowadays, so risk is lower than in the past, but worth a check anyway).

@dims
Copy link
Copy Markdown
Member Author

dims commented Apr 27, 2026

@sttts poked at it with some agents, the main thing that showed up was a change in IsFloat64AJSONInteger. which didn't seem too bad to me.

SHA Message Author
9b27996 improve equality comparison for floats @afansv
df12219 IsFloat64JSONInteger check: fixed short-circuit case; benchmark confirms ~14% faster @fredbi
24f77a7 experimental code to compare rounding methods @fredbi

The core algorithm change (uint64 truncation → math.Round) is in 9b27996. The short-circuit fix and benchmark validation are in df12219.

See https://gist.github.com/dims/ecd681ea7d4748300d3b6203074e7d70 for the full gist.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2026
@Jefftree
Copy link
Copy Markdown
Member

@dims need a rebase on this one since the SHA pinning already merged: #592

dims added 3 commits April 30, 2026 10:54
go-openapi/swag v0.25.4 refactored into sub-modules that no longer
depend on github.com/mailru/easyjson. The root package re-exports all
the same symbols so no import changes are needed.

The go directive bumps to 1.24.0 (required by swag sub-modules), which
also surfaces two pre-existing vet errors (non-constant format strings)
fixed here.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Go 1.23 is no longer tested; Go 1.26 is added to the matrix.
Update verify-go-directive.sh bound to 1.24.0 to match the
minimum go directive now required by go-openapi/swag v0.25.4.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Run go mod tidy to pick up the swag sub-module deps and go 1.24
directive inherited from the root module upgrade.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 30, 2026
@dims
Copy link
Copy Markdown
Member Author

dims commented Apr 30, 2026

@Jefftree Done!

@Jefftree
Copy link
Copy Markdown
Member

Jefftree commented May 1, 2026

/lgtm

pkg/validation will require either @sttts @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2026
@liggitt
Copy link
Copy Markdown
Member

liggitt commented May 2, 2026

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2026
@k8s-ci-robot k8s-ci-robot merged commit b7f5293 into kubernetes:master May 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants