drop mailru/easyjson by upgrading go-openapi/swag to v0.25.4#590
drop mailru/easyjson by upgrading go-openapi/swag to v0.25.4#590k8s-ci-robot merged 3 commits intokubernetes:masterfrom
Conversation
|
/approve Excellent. Thanks! |
|
@dims how deep have you looked into potential behaviour changes? go-openapi has some reputation of changing semantics without notification by accident. As we use it in our CRD validation there is risk that we break our API (we have forked the go-openapi validator nowadays, so risk is lower than in the past, but worth a check anyway). |
|
@sttts poked at it with some agents, the main thing that showed up was a change in
The core algorithm change ( See https://gist.github.com/dims/ecd681ea7d4748300d3b6203074e7d70 for the full gist. |
go-openapi/swag v0.25.4 refactored into sub-modules that no longer depend on github.com/mailru/easyjson. The root package re-exports all the same symbols so no import changes are needed. The go directive bumps to 1.24.0 (required by swag sub-modules), which also surfaces two pre-existing vet errors (non-constant format strings) fixed here. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Go 1.23 is no longer tested; Go 1.26 is added to the matrix. Update verify-go-directive.sh bound to 1.24.0 to match the minimum go directive now required by go-openapi/swag v0.25.4. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Run go mod tidy to pick up the swag sub-module deps and go 1.24 directive inherited from the root module upgrade. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
|
@Jefftree Done! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, jpbetz, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
go-openapi/swag v0.25.4 refactored into sub-modules that no longer depend on github.com/mailru/easyjson. The root package re-exports all the same symbols so no import changes are needed.
The go directive bumps to 1.24.0 (required by swag sub-modules), which also surfaces two pre-existing vet errors (non-constant format strings) fixed here.