Mask Linux thermal interrupt info in /proc and /sys.#131018
Mask Linux thermal interrupt info in /proc and /sys.#131018k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
|
looks like we need darwin support too! (typecheck fail) |
On Linux, mask "/proc/interrupts" and "/sys/devices/system/cpu/cpu<x>/thermal_throttle" inside containers by default. Privileged containers or containers started with --security-opt="systempaths=unconfined" are not affected. Mitigates potential Thermal Side-Channel Vulnerability Exploit (https://github.com/moby/moby/security/advisories/GHSA-6fw5-f8r9-fgfm). Also: improve integration test TestCreateWithCustomMaskedPaths() to ensure default masked paths don't apply to privileged containers. Refers to moby/moby#49560 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
d3a2c9d to
65b8fba
Compare
|
/retest |
|
/test pull-kubernetes-e2e-capz-windows-master |
|
/retest |
1 similar comment
|
/retest |
|
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
pull-kubernetes-e2e-capz-windows-master is mostly red over all PR's 🤔 |
|
Changelog suggestion -Mask Linux thermal interrupt info in `/proc` and `/sys`.
+Masked off access to Linux thermal interrupt info in `/proc` and `/sys`. |
Thanks, applied as suggested. |
|
/triage accepted |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
/hold cancel |
|
ah /hold I see, let's let a kubelet approver look |
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
/lgtm
/unhold
/approve
We typically keep these in-sync.
I wonder if it warrants the backport. I do not have access to https://github.com/moby/moby/security/advisories/GHSA-6fw5-f8r9-fgfm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes, I think so. Opened #132985, #132986 and #132987 for that. |
…f-#131018-base-release-1.31 Automated cherry pick of #131018: Mask Linux thermal interrupt info in /proc and /sys.
…f-#131018-base-release-1.32 Automated cherry pick of #131018: Mask Linux thermal interrupt info in /proc and /sys.
…f-#131018-base-release-1.33 Automated cherry pick of #131018: Mask Linux thermal interrupt info in /proc and /sys.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
On Linux, mask "/proc/interrupts" and "/sys/devices/system/cpu/cpu/thermal_throttle" inside containers by default. Privileged containers or containers started with --security-opt="systempaths=unconfined" are not affected.
Mitigates potential Thermal Side-Channel Vulnerability Exploit (https://github.com/moby/moby/security/advisories/GHSA-6fw5-f8r9-fgfm).
Also: improve integration test TestCreateWithCustomMaskedPaths() to ensure default masked paths don't apply to privileged containers.
Which issue(s) this PR fixes:
Refers to moby/moby#49560, cri-o/cri-o#9069
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: