defaultservicecidr controller no shutdown eventbroadcaster on start#133338
defaultservicecidr controller no shutdown eventbroadcaster on start#133338k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
The defaultservicecidr controller runs as an apiserver PostStartHook hence can not block the startup. The logic of the controller was copied from the common boilerplate and was assuming the controller blocked on start, hence defering the shutdown of the eventbroadcaster. Only shutdown the eventbroadcaster when the context is done. Change-Id: I70426d5550afe3b12ab5ea68746238dd96f7db52
k8s-ci-robot
added
release-note
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-priority
|
/assign @danwinship |
k8s-ci-robot
added
sig/api-machinery
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| go func() { | ||
| <-ctx.Done() | ||
| klog.Infof("Shutting down %s", controllerName) | ||
| c.eventBroadcaster.Shutdown() |
There was a problem hiding this comment.
someone ought to context-ify EventBroadcaster...
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: cad7b6a09401eff1ce090d42e95144ec7ad4e138 |
|
/remove-sig api-machinery |
k8s-ci-robot
removed
the
sig/api-machinery
4 participants
The defaultservicecidr controller runs as an apiserver PostStartHook hence can not block the startup.
The logic of the controller was copied from the common boilerplate and was assuming the controller blocked on start, hence defering the shutdown of the eventbroadcaster.
Only shutdown the eventbroadcaster when the context is done.
/kind bug
Fixes: #133306