Change WaitForNamedCacheSync to WaitForNamedCacheSyncWithContext

[aditigupta96]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Change WaitForNamedCacheSync to WaitForNamedCacheSyncWithContext.

Which issue(s) this PR is related to:

Contributes to #126379

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

Hi @aditigupta96. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[itzPranshul]

As i understand what the issue says is to add alternative APIs<something>WithContext while existing the current one for downstream consumers. Also this change wrapping the c.runWorker() inside a anonymous function seems to ignore the ctx.It technically uses UntilWithContext, but the worker itself is still context-unaware. Althrough i might be wrong about this

[Jefftree]

/ok-to-test

[Jefftree]

/cc @pohly

I'm a bit confused about the function WaitForNamedCacheSyncWithContext. The signature makes it look like a wrapper around WaitForCacheSync while the name indicates it's a wrapper around WaitForNamedCacheSync. Is there precedent on how the controllerName variable gets handled in WaitForNamedCacheSyncWithContext?

[aditigupta96]

@Jefftree There's no need to manually add the controller name to the context. kube-controller-manager takes care of this at a higher level, the controller code doesn't have to (and shouldn't) do it again (as discussed on slack).

Code Reference: https://github.com/kubernetes/kubernetes/blob/release-1.34/cmd/kube-controller-manager/app/controllermanager.go#L753

[benjaminapetersen]

/assign stlaz

[aditigupta96]

/assign sig-apps-approvers

[k8s-ci-robot]

@aditigupta96: GitHub didn't allow me to assign the following users: sig-apps-approvers.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign sig-apps-approvers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pohly]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 9be8907e943b62ad84727bc950d25b659dfe2426

[Jefftree]

/triage accepted

[janetkuo]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aditigupta96, janetkuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/controller/OWNERS [janetkuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aditigupta96]

/release-note-none

[aditigupta96]

/retest

[k8s-ci-robot]

@aditigupta96: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-integration	7d14367	link	unknown	/test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[aditigupta96]

/retest